From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 0E36D3858D32 for ; Tue, 2 Jan 2024 15:02:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E36D3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E36D3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704207722; cv=none; b=fWPojPIGtEYGO7aaG5egAfRHmfZzpWKNoO/qgM73muyvRcNGseJ6/ZU5r4O3nFsaM1tVmmzPvHb13vMnqtYOG7YwnponN9G2wseA+3kYBg3iTnfbl5G/olqCfSW59GveBAPOhL0H4nlsLkSIeKtYkJQ5h2QSTLfb0U7Vrf72mpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704207722; c=relaxed/simple; bh=6HKMvUbTneOR6zCuTAoIGdV6wORQqzxXDnHSGXqcoww=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=xLYKLMl7PngyznCen3EETD+tXqxhS46vjbqhCi6Sb8OkS5UuLnRHZckQ/ZKbNcPGabpg/Aq+R7VTbEilbUc5c0xiiUh32DKMLLUgeYb9Fe9DF9vtOfCDD9M9RYH470Dp82VfxDgxzl2rLiB8m+pjvnkb9ZgPuHwlz8QWgK1xxCs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id CD6578115E; Tue, 2 Jan 2024 15:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1704207719; bh=6HKMvUbTneOR6zCuTAoIGdV6wORQqzxXDnHSGXqcoww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c3Hh5Uc9oi7GMNPDKDV5XRy9kqUxhiTs1/C5Hqp+hU82e/03GRiND6/6qJ+vVvhkd PoJYnFHUigLxg1T/cRSzWLjGVuG93lEtnQthJNTClQ5xR/sYVU+C0ZnGnuPMJK9Dkv sUZMreTrIj+m6mxl0WPNZWHbrOX7ST5WLdNcFbD5PiMovpLq2rSnTpWTNLuZs8IeY1 YUQKKV9YuzXTOWIu7EjurVq4n4POE2aM+jOUGq1u4c8xqg8qyo7fXuXm4PnHxf4t2X E1QGjkvWuqCm8UgsVMPBl33FPP0dweIRQKn70Z4r5RH4Y4rDKNqGarWymZ/K1MdC6j y5YiEQjnxZfYA== Date: Tue, 2 Jan 2024 15:01:53 +0000 From: Lancelot SIX To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 2/3] gdb: merge error handling from different expression parsers Message-ID: <20240102150142.43m4ycd7thwezwe3@octopus> References: <06889e172a22e80af44b30b1e70f1f06ecb3ba96.1704206350.git.aburgess@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <06889e172a22e80af44b30b1e70f1f06ecb3ba96.1704206350.git.aburgess@redhat.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Tue, 02 Jan 2024 15:01:59 +0000 (UTC) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andrew, Just a nit below > diff --git a/gdb/parser-defs.h b/gdb/parser-defs.h > index 93ebdf5c061..4d40245228b 100644 > --- a/gdb/parser-defs.h > +++ b/gdb/parser-defs.h > @@ -262,6 +262,11 @@ struct parser_state : public expr_builder > push (expr::make_operation (std::move (lhs), std::move (rhs))); > } > > + /* Function called from various the various parsers yyerror functions to I think the first "various" came from some previous wording and should be dropped. Best, Lancelot. > + throw an error. The error will include a message identifying the > + location of the error within the current expression. */ > + void parse_error (const char *msg); > + > /* If this is nonzero, this block is used as the lexical context for > symbol names. */ > > -- > 2.25.4 >