public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Matheus Branco Borella <dark.ryu.550@gmail.com>
To: gdb-patches@sourceware.org
Cc: Matheus Branco Borella <dark.ryu.550@gmail.com>
Subject: [PATCH] Make `linux_info_proc` prefer using the LWP over the PID
Date: Fri,  5 Jan 2024 23:45:13 -0300	[thread overview]
Message-ID: <20240106024512.14270-1-dark.ryu.550@gmail.com> (raw)

Fixes: https://sourceware.org/bugzilla/show_bug.cgi?id=31207

Normally, `linux_info_proc` would use the PID to determine which subfolder in
`/proc` to read information from. While this is usually fine, it breaks down
after the main thread exits, at which point the information in `/proc/$pid`
becomes become unreliable, if it is available at all. While it is the case
that most programs terminate after their main thread exits, some may continue
running from detached threads, in which case `info proc` will start misbehaving.

This patch addresses this by making it so that the LWP - the Lightweight Process
ID, that, in the case of GNU/Linux is the number of the process backing up the
thread[1] - is prefered over the PID. By doing this, `linux_info_proc` will
always access valid procfs information, even after the main thread exits.

[1]: https://man7.org/linux/man-pages/man2/clone.2.html
---
 gdb/linux-tdep.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index 82e8bc3db3c..2c91e298d45 100644
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -840,7 +840,14 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
       if (current_inferior ()->fake_pid_p)
 	error (_("Can't determine the current process's PID: you must name one."));
 
-      pid = current_inferior ()->pid;
+      /* Seeing as, when the main thread exits, the information in /proc/$pid
+       * becomes unreliable, we should prefer using the current TID, whenever
+       * possible. */
+      pid = inferior_ptid.lwp ();
+
+      /* And fall back to the actual PID only when the TID is not available. */
+      if (pid == 0)
+	pid = current_inferior ()->pid;
     }
 
   args = skip_spaces (args);
-- 
2.40.1


             reply	other threads:[~2024-01-06  2:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06  2:45 Matheus Branco Borella [this message]
2024-01-08 15:50 ` Simon Marchi
2024-01-19 16:52   ` Matheus Branco Borella
2024-01-19 16:49 ` [PATCH v2] " Matheus Branco Borella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240106024512.14270-1-dark.ryu.550@gmail.com \
    --to=dark.ryu.550@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).