From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 071843858C74 for ; Tue, 9 Jan 2024 17:54:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 071843858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 071843858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704822847; cv=none; b=GWiqsbUdsZ+L8o+L5g2GCsXAZFRemkpSVRqhQ4pnCyaiFhsLot3sr1Oi9tt5S+LDMF1Yjv+Dl2n1BEmsMsRxjykyu3QTFM9YzpgFLKgTWlnek5xTOrELi9K9GIG0XS06ETkPaW1pY6u96z3nOEIxSDa+VOMqPJH1Dsx3YqjeGdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704822847; c=relaxed/simple; bh=/2lILo37hK/oqJlDaGO+1aT1Q+CRxjDDZOP37WLco0Q=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=JPupz9+qjvttB0lNyn6pAJmNWyNqwUM7Bi6+WjBUOOgPDzHKyHzMy3j4Zky4dtPZbCdgu/Pvc0o/hEeTpYYLPcZFIPZB4zmnKFRhBYDgIJW/uw51+D1uPCVZNV6eZUuFtBlbsz2oot6IfTNtqVbhhmspynQeHkSujWV91zB5KIM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704822845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qCb0SHQMNkCXl2wBpnVfKgPFihDX36Dzl0nqmKzDZYc=; b=ROiu68cES9DKBKKFPdP5rfoAQ2XSbO1n6ZBJlk+WPoNg0ezhr7l406adbAz4bSwoRuVFMq 02UQwhmIjHEHYhv8I4GMIwqiOxjXVXVue9MISU2YeqoYM9NNummLAT23ZdNfsi0dc6nkoB AuEEc3G0mkNzChvcaxtROhVbgBESxr4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-QpyQCD28Obe1QzmLtFuDdw-1; Tue, 09 Jan 2024 12:54:04 -0500 X-MC-Unique: QpyQCD28Obe1QzmLtFuDdw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2477C38212C2; Tue, 9 Jan 2024 17:54:03 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.32.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE7B21121306; Tue, 9 Jan 2024 17:54:02 +0000 (UTC) Date: Tue, 9 Jan 2024 10:54:01 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] [gdb] Make variable printed bool in info_checkpoints_command Message-ID: <20240109105401.4177bec1@f39-zbm-amd> In-Reply-To: <20240108152553.4578-2-tdevries@suse.de> References: <20240108152553.4578-1-tdevries@suse.de> <20240108152553.4578-2-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 8 Jan 2024 16:25:51 +0100 Tom de Vries wrote: > While reading info_checkpoints_command, I noticed variable printed: > ... > const fork_info *printed = NULL; > ... > for (const fork_info &fi : fork_list) > { > if (requested > 0 && fi.num != requested) > continue; > > printed = &fi; > ... > } > if (printed == NULL) > ... > has pointer type, but is just used as bool. > > Make this explicit by changing the variable type to bool. > > Tested on x86_64-linux. LGTM. Approved-By: Kevin Buettner