From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 041AF3858C52 for ; Wed, 10 Jan 2024 05:28:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 041AF3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 041AF3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704864506; cv=none; b=Pahll45TcS5isGWhDTct9JmbBn9VZwOSe8ZdKMpEJDSUE+CuoixJUV16hugkJcIj7ppmEw4tlY/hTH2guNn5iPx6Rx4JxsuamPOTJlv0OgLw7kWxm1bC+GS9zPfiHq6fPSgFqoODep3wqOZH0IQxzuAzoZ/0Itu7nYpj6ZjoGHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704864506; c=relaxed/simple; bh=hilUuYkMRVCqiORhy4Szfp0zn+fqCMnBRtxR1JQB8SE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Tku44ceyKD2dHADHtqeZYQ8AhTQDffKeaQEf3NAxmIPUTXyFWmI1gmK0Fg+2MB34qYl1csixdwy2HyTEYNlVOsvEier4werDB13OeOp3fTZMNza1C8ydtjt9yK9zzgExvvNOzHYT8flXQ/zVaIyFGJt8lDaEjB/f8zJQKFJq7W0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704864504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RYq1/X1kxt46LOhxkQI5PwV5OyycAoHrhWSb8JlXfIk=; b=QcvfOkiab+84D1xm5eNnhCuhMZcJfrg+b96d1wa7wN3wjj5iZIV4lJh3xWv6Swf8ymu3uB 7K6EDSYX9ude2K8bx3U8tV4ACMIrAkGLneK3rHTgt3GsioOC0tsHnnVa2wZxsWQG3J7OPY 7WhblyHvwTr9qMLYFPmkc4L53EtS8xk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-QsgiZukUOd22Soo6OiRt0A-1; Wed, 10 Jan 2024 00:28:21 -0500 X-MC-Unique: QsgiZukUOd22Soo6OiRt0A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 126D082DFE8; Wed, 10 Jan 2024 05:28:21 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.32.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC887C15E6A; Wed, 10 Jan 2024 05:28:20 +0000 (UTC) Date: Tue, 9 Jan 2024 22:28:19 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] [gdb] Fix assertion failure for checkpoint delete 0 Message-ID: <20240109222819.42d20c22@f39-zbm-amd> In-Reply-To: <20240108152553.4578-4-tdevries@suse.de> References: <20240108152553.4578-1-tdevries@suse.de> <20240108152553.4578-4-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 8 Jan 2024 16:25:53 +0100 Tom de Vries wrote: > When doing "checkpoint delete 0" we run into an assertion failure: > ... > +delete checkpoint 0 > inferior.c:406: internal-error: find_inferior_pid: Assertion `pid != 0' failed. > ... > > Fix this by handling the "pptid == null_ptid" case in > delete_checkpoint_command. > > Tested on x86_64-linux. > > PR gdb/31209 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id The Bug URL above is missing an '=31209' at the end. Otherwise, LGTM. Approved-By: Kevin Buettner Kevin