From: Toby Lloyd Davies <tlloyddavies@undo.io>
To: gdb-patches@sourceware.org
Cc: Toby Lloyd Davies <tlloyddavies@undo.io>
Subject: [PATCH] gdb/infcall: Fix freed frame dereferenced in inferior call
Date: Thu, 11 Jan 2024 16:38:26 +0000 [thread overview]
Message-ID: <20240111163826.286722-1-tlloyddavies@undo.io> (raw)
Between the store to frame and it's use by get_frame_sp (frame) there is
a call to find_function_addr(). If the function is a IFUNC then this can
do another inferior call. This results in the frame cache being
invalidated which frees all frames. Then the frame pointer previously
stored is left dangling and get_frame_sp (frame) may segfault.
---
gdb/infcall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/infcall.c b/gdb/infcall.c
index 8252feea074..15dce04c984 100644
--- a/gdb/infcall.c
+++ b/gdb/infcall.c
@@ -938,6 +938,7 @@ call_function_by_hand_dummy (struct value *function,
/* Ensure that the initial SP is correctly aligned. */
{
+ frame = get_current_frame ();
CORE_ADDR old_sp = get_frame_sp (frame);
if (gdbarch_frame_align_p (gdbarch))
--
2.34.1
next reply other threads:[~2024-01-11 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 16:38 Toby Lloyd Davies [this message]
2024-01-11 17:26 ` Tom Tromey
2024-01-11 18:19 ` Toby Lloyd Davies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111163826.286722-1-tlloyddavies@undo.io \
--to=tlloyddavies@undo.io \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).