From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 284763858D3C for ; Sun, 14 Jan 2024 08:36:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 284763858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 284763858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705221390; cv=none; b=cTw8l51jOsHHRy9UTfGNNJkjaZbqAU5Ao7AazOSG3CiI0LbmPcdsljsriNW++/zewKUcoDW5ygSeNaM9rv1OMwf4S+fjB5ByOD6vTQT6QUjMe5nDd7YpKsioWvPDUJz8b3gDd3LaXJfG+3V70wTvk9pL5BzuCXaK/8cApLCkuU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705221390; c=relaxed/simple; bh=FdcZ//D1wpTBviNanAxAmxTbW/h8PbjiUFJCe3301wI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=vMZVPh4w3lQEhgUgtgM2Ho1+7XYdppivtZJJ9eIOXzlSkxVAq0Vcc19ZNlMDwW792g5YgkKO9tSzNmhxahCKfICGjXrk45zbK041oIuxTim7nE55DhxnPZ5KLBVopt5mtQ94phkUCkrHHCA8UpEbG0gnfSV3rcxIdnCpeo2wcGY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B53D121DB2 for ; Sun, 14 Jan 2024 08:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705221378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvUMyUwqbCU3eE9ThqdnCNYhr3d/g1dXj7gu/5E1FJA=; b=AJIB6wTcyDG91x6naWvo99vtXuly3YGt7VgrTkSxD1Eo0JTOlylAYFjgZU0y+gR4hP3Cpw do+yCCFpS7a9MTrdCA93m6gPA6/2DYxHngkqz6fnK7SDAGXcWjwU9r0q9m5ITmkFr6vfs4 B2QLpVBPijuns9deMWx2dh1b+mE3COA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705221378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvUMyUwqbCU3eE9ThqdnCNYhr3d/g1dXj7gu/5E1FJA=; b=ReYbfJyMSQh1DzGAuFRvuBcJpijk5MzrPPs5v7YDndaJeczdQlM3HGipBH479lrKLdnFrJ dFpx542AMAwWQgDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705221378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvUMyUwqbCU3eE9ThqdnCNYhr3d/g1dXj7gu/5E1FJA=; b=AJIB6wTcyDG91x6naWvo99vtXuly3YGt7VgrTkSxD1Eo0JTOlylAYFjgZU0y+gR4hP3Cpw do+yCCFpS7a9MTrdCA93m6gPA6/2DYxHngkqz6fnK7SDAGXcWjwU9r0q9m5ITmkFr6vfs4 B2QLpVBPijuns9deMWx2dh1b+mE3COA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705221378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvUMyUwqbCU3eE9ThqdnCNYhr3d/g1dXj7gu/5E1FJA=; b=ReYbfJyMSQh1DzGAuFRvuBcJpijk5MzrPPs5v7YDndaJeczdQlM3HGipBH479lrKLdnFrJ dFpx542AMAwWQgDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9F36B13963 for ; Sun, 14 Jan 2024 08:36:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XONhJQKdo2WoeQAAD6G6ig (envelope-from ) for ; Sun, 14 Jan 2024 08:36:18 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Fix gdb.cp/namespace.exp with read1 Date: Sun, 14 Jan 2024 09:37:05 +0100 Message-Id: <20240114083705.28962-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 3.72 X-Spamd-Result: default: False [3.72 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.18)[-0.922]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[10.09%] X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: With check-read1 we run into: ... (gdb) break DNE>::DNE^M Function "DNE>::DNE" not defined.^M Make breakpoint pending on future shared library load? (y or [n]) y^M Breakpoint 9 (DNE>::DNE) pending.^M n^M (gdb) FAIL: gdb.cp/namespace.exp: br malformed '>' (got interactive prompt) n^M ... The question is supposed to be handled by the question and response arguments to this gdb_test call: ... gdb_test "break DNE>::DNE" "" "br malformed \'>\'" \ "Make breakpoint pending on future shared library load?.*" "y" ... but both this and the builtin handling in gdb_test_multiple triggers. The cause of this is that the question argument regexp is incomplete. Fix this by making sure that the entire question is matched in the regexp: ... set yn_re [string_to_regexp {(y or [n])}] ... "Make breakpoint pending on future shared library load\\? $yn_re " "Y" ... Tested on x86_64-linux. --- gdb/testsuite/gdb.cp/namespace.exp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.cp/namespace.exp b/gdb/testsuite/gdb.cp/namespace.exp index 79e9cb1ac79..504359d4998 100644 --- a/gdb/testsuite/gdb.cp/namespace.exp +++ b/gdb/testsuite/gdb.cp/namespace.exp @@ -251,8 +251,9 @@ gdb_test "print AAA::ALPHA" "\\$\[0-9\].* = AAA::ALPHA" gdb_test "whatis ::C::CClass::NestedClass" "type = C::CClass::NestedClass" gdb_test "whatis ::C::CClass::NestedClass *" "type = C::CClass::NestedClass \\*" +set yn_re [string_to_regexp {(y or [n])}] # Break on functions with a malformed name. gdb_test "break DNE>::DNE" "" "br malformed \'>\'" \ - "Make breakpoint pending on future shared library load?.*" "y" + "Make breakpoint pending on future shared library load\\? $yn_re " "Y" gdb_test "break DNE)::DNE" "" "br malformed \')\'" \ - "Make breakpoint pending on future shared library load?.*" "y" + "Make breakpoint pending on future shared library load\\? $yn_re " "Y" base-commit: f4be2092294eb23cbc52c8b891993351de7a134e -- 2.35.3