From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BA49538582BB for ; Mon, 15 Jan 2024 19:09:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA49538582BB Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA49538582BB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705345754; cv=none; b=EZH84QHT0Nzzfnum35XopuPKUQDTdCS9aRtbfCAAQsVeEUSbE52G8yRZXOzs5RqX+yBuf40urnR09dw4xuHkqnC8vq8GmiDsoYHCIo+VykPSiaLSBvkOQDp58y7N4+qC/sA2X4R2Ga6V3teqQ0IMRHEJ7c/bQFg4sGShXKtjBLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705345754; c=relaxed/simple; bh=4UZ80BP7phARC96mI3cVIM+RJVbKLomCsu4AQ9+OMHA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=jeVY63InZBE1zM/sgS/LfEWioTRz9yudMgnmU/JgnUZQYF93UADW3RfEL4qVRP2Odhv5vpb9H719j+NwPNHkTjVIdrtcuwIdgzByJADcO109ZMRcDqkeq5/8+FO9ABOur1iO4kFH6Qtu+g2TSrsqDkuPlKjkaPk5U+QaqK70r+w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 473D71E092; Mon, 15 Jan 2024 14:09:11 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdb/testsuite: remove spurious $ in save_vars Date: Mon, 15 Jan 2024 14:09:09 -0500 Message-ID: <20240115190910.74114-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3496.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I noticed that running the whole testsuite in serial mode (which means all the .exp files are ran in the same TCL environment, one after the other) with the native-extended-gdbserver board caused some weird failures, for instance a lot of internal errors in the reverse tests, like: continue^M Continuing.^M /home/jenkins/workspace/binutils-gdb_master_linuxbuild/platform/deb12-amd64/target_board/native-extended-gdbserver/src/binutils-gdb/gdb/remot e.c:6922: internal-error: resume: Assertion `scope_ptid == inferior_ptid' failed.^M A problem internal to GDB has been detected,^M further debugging may prove unreliable.^M ----- Backtrace -----^M FAIL: gdb.reverse/break-precsave.exp: run to end of main (GDB internal error) This only happens after running gdb.multi/attach-while-running.exp. That test does not restore GDBFLAGS properly when it's done, it leaves `-ex \"maint set target-non-stop on\""` in there, which breaks some subsequent tests. The problem is that this line: save_vars { $::GDBFLAGS } { should not use a `$` before the variable name. Passes the content of `::GDBFLAGS` to save_vars, which is not what we want. We want to pass the `::GDBFLAGS` string. Fix that. Change-Id: I5ad32c527795fd10d0d94020e4fd15cebaca3a77 --- gdb/testsuite/gdb.multi/attach-while-running.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.multi/attach-while-running.exp b/gdb/testsuite/gdb.multi/attach-while-running.exp index c0201418de65..eade8b42a18e 100644 --- a/gdb/testsuite/gdb.multi/attach-while-running.exp +++ b/gdb/testsuite/gdb.multi/attach-while-running.exp @@ -43,7 +43,7 @@ if { [build_executable "failed to prepare" ${testfile} ${srcfile}] } { } proc do_test {} { - save_vars { $::GDBFLAGS } { + save_vars { ::GDBFLAGS } { append ::GDBFLAGS " -ex \"maint set target-non-stop on\"" clean_restart $::binfile } base-commit: a73afeff18db7304495bf7c42b25f3b93645b46f -- 2.43.0