From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 1B6583858003 for ; Wed, 17 Jan 2024 16:39:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B6583858003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B6583858003 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705509586; cv=none; b=Az79Fh9o7aFjmaq6avwjAp0tSHDDAob3vQOxmyRhpmB+zZ8jYtjRky553ay34qzp2mASE3+Icjk6GWPYp8YGQB32WSot3h8lXVS5JWApVBqKvPtegPhghzDyzRcHwwWSwTg670hlkZp/PbOCClPClzeZU3xD2xTkrX/Bjx4rJv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705509586; c=relaxed/simple; bh=OhaZdgsgn+wDF4wGUklOtEhisSz5V0BI0uMRy0fuuwE=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=OqMQPu7XGMJB+7J3aGWmi++C+KNh1HZ4cniiOaF4uR2CfxuAo6C4Sd8bfEcr8k35BcBXLBFQ640/p2IXgLK9h1sP0+mXOLXXvcjbHmllzO995jkZjWz6gZDtLS+hFYcnUt9arYpknHjgTdfdx2rQXX4+hKypNRfeKQLfW/QbdUY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id PpbRrUkbRoMN9Q8x3rBJOm; Wed, 17 Jan 2024 16:39:41 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Q8x1rVdjQKleDQ8x2rxCHA; Wed, 17 Jan 2024 16:39:40 +0000 X-Authority-Analysis: v=2.4 cv=KcbBDCUD c=1 sm=1 tr=0 ts=65a802cc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=0m2rpFkAjy4yp5XdhikA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=40uiCPvIR18RwNtV5KOtfhggb9u6Jab392dtvSXBSA4=; b=IkRyh/jwF7bFXQv9csS+zrflNf ty6HgZfsvTZWmqUHz2Ax03DcHPk0sRKqPnH7nJE6BBCTx0G8NTviI8P6THOoNaDVf00VtE3/pPgW3 u4+zr7s6JMvM/IuHCjaTHpFpG; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:56636 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rQ8x1-002OXE-1g for gdb-patches@sourceware.org; Wed, 17 Jan 2024 09:39:39 -0700 From: Tom Tromey Date: Wed, 17 Jan 2024 09:39:42 -0700 Subject: [PATCH v2 14/17] Allow other results in DW_TAG_entry_point test MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240117-debug-names-fix-v2-14-dbd5971a9c31@tromey.com> References: <20240117-debug-names-fix-v2-0-dbd5971a9c31@tromey.com> In-Reply-To: <20240117-debug-names-fix-v2-0-dbd5971a9c31@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQ8x1-002OXE-1g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:56636 X-Source-Auth: tom+tromey.com X-Email-Count: 19 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJmRXl5CY12TPQ5vLIMOExeLvzebeICinYGui94tbOjt3BUddAlFqLda+Tpx8ZJfmJgeYYdUIV6jLDpD2YgQO2RcMg0dg8Da4Wjs+x+Or/WN1/6A4hwt wQdC0Yn9WzeXYJnlJeVtz4U2R2NNXijwiXaoqZNcfPguIiEdzU6tXKzpBB3oIozBu4p+o0/eL36mna37BVupJSFIPpH9zGb2vr8= X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: DW_TAG_entry_point is implemented by adding a new LOC_BLOCK symbol -- that is, another function symbol. However, the test case assumes that "bt" will never pick this symbol. This assumption seems unwarranted to me, and in fact this test will regress with the debug-names target board after the .debug_names rewrite. This patch changes the test to allow either answer in the backtrace. If only the main entry point is desired, then it seems that more work must be done to handle DW_TAG_entry_point properly, as nothing currently guarantees this property. --- gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp b/gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp index c0c7a7ca542..632a31111a2 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp @@ -207,7 +207,10 @@ if ![runto_main] { gdb_breakpoint "*fooso" gdb_continue_to_breakpoint "foo_so" +# Note that because DW_TAG_entry_point is entered as a LOC_BLOCK +# symbol, exactly which symbol is shown in the stack trace depends on +# which symbol gdb happens to find first in the lookup. gdb_test "bt" [multi_line \ - "#0.*${hex} in foo \\(J=1, K=0\\).*" \ + "#0.*${hex} in (foo|fooso) \\(J=1, K=0\\).*" \ "#1.*${hex} in prog \\(\\).*" \ ] "bt fooso" -- 2.43.0