From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 4CB383858C53 for ; Thu, 18 Jan 2024 20:32:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CB383858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CB383858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609933; cv=none; b=SMKEZefh7ffhw0aWIrrZAIqVyu+1duUnNnJhdWm9ZaE+YktKNoRr1BKnWLv6svBY5WVeVje3UPJv3uujeg3lpO/Lrw23HfwjEBiSORf/m9CVD7a3cUSkzmdDDPEpDlSPs91p+1n7a2geXHvFiRPKbjqeqxcJeaYfe4hOsEsRnDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609933; c=relaxed/simple; bh=zeQCNFTuTyd5DFISTNgzo8fXtz3xInmzdy4T7HwQO9E=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=OKIqnHawNf/AGOdbGoij0LP0bJPXqubbM3PDD5QL5imWStdOQarFoI/wJVelkKQI1EkVByAZqXSV2q5q4ZIUFXqYW0bqiLv+2os4ZIWjbWmGlI6bJ5uuY7yTMmyaPovfWTp2Kil7DxIWTbqyRR+cmRgvsykT2j92gLZCEWOxBz8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6005a.ext.cloudfilter.net ([10.0.30.201]) by cmsmtp with ESMTPS id QViwrN2eYMVQiQZ3YrEcPn; Thu, 18 Jan 2024 20:32:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QZ3XrrEwQ1UTRQZ3Xrmnb5; Thu, 18 Jan 2024 20:32:07 +0000 X-Authority-Analysis: v=2.4 cv=ZOXEJF3b c=1 sm=1 tr=0 ts=65a98ac7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=N5RK8avXPxMtqR0ytacA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5ZGzgdLrbQ9sFTSQgh1tB4Yb2j8aK8kiKYYON2e4xEY=; b=n4Hapay+OjGBpqM1iI3Zj93j3h TMkiPR0Cg5XesbiKdyl/85UTlTzXoFsfEW8A6exhNuUywL3TAjuGPZ0A1kd5+dGeyRqZoJ/YcDaoK ec78zuFccML788GRQaVDt7Xgt; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:50746 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rQZ3X-002DCj-0M for gdb-patches@sourceware.org; Thu, 18 Jan 2024 13:32:07 -0700 From: Tom Tromey Date: Thu, 18 Jan 2024 13:31:59 -0700 Subject: [PATCH v2 01/30] Fix bug in cooked index scanner MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240118-submit-domain-hacks-2-v2-1-aecab29fa104@tromey.com> References: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> In-Reply-To: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQZ3X-002DCj-0M X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:50746 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPLafGjFBcF2ghcjtbXhpWiHRhdM88FFxZKLkqgHjuAvPSQR91xDfUb3E7wAPoaS8LkYL95e/zIYB7Z0UU5UjbLLCjjyDi+zVo/H3QZgOy9VVVp844ly CZ+29T3zE3+2q0YmSCKnq5f5NNlcPViTP+keRj+k85qYsmr7T2ihAlRruHD94J7sYmO7nnL/Q5Pql3s2+m0K7/n+xHnC/YsF4Co= X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Testing this entire series pointed out that the cooked index scanner disagrees with new_symbol about certain symbols. In particular, new_symbol has this comment: Ada and Fortran subprograms, whether marked external or not, are always stored as a global symbol, because we want This patch updates the scanner to match. I don't know why the current code does not cause failures. It's maybe worth noting that incremental CU expansion -- creating symtabs directly from the index -- would eliminate this sort of bug. --- gdb/dwarf2/read.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 8f2b7a35f27..7b523d93e07 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -16405,6 +16405,12 @@ cooked_indexer::scan_attributes (dwarf2_per_cu_data *scanning_per_cu, || abbrev->tag == DW_TAG_enumeration_type || abbrev->tag == DW_TAG_enumerator)) *flags &= ~IS_STATIC; + + /* Keep in sync with new_symbol. */ + if (abbrev->tag == DW_TAG_subprogram + && (m_language == language_ada + || m_language == language_fortran)) + *flags &= ~IS_STATIC; } return info_ptr; -- 2.43.0