From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 5D5763858C56 for ; Thu, 18 Jan 2024 20:32:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D5763858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5D5763858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609933; cv=none; b=ZOYhatLvO4fTSbfGuXYW/RwHd5ADIWv2c2G9swC6BIoX+pGhrESxovk+sbBIucrRlLIZ4+ykXbwXWevnBAcLj53kIH6FeS0L4T3RjTJjJ2d9bX/6eIWpoxCGYjSzwicVdv3J0u5FVQtgTD81eG93s54j79u4u+IbobU5uKNGynk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609933; c=relaxed/simple; bh=Hcc79opCBSztboDTBWZrjjZu2b+YmRYHKRphKc1vWI4=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=fwqiP8yV6bNIqipjiWufh9TCiuPeHulVSdQygF7MCqMPCkjCfUD7bY2/y4pQaOVDevYW/NzyQi0TsiR3a2t7O3yPvggNitVzvXUZQTU92XhaYFjwPm5TdTSW358xwu/atIP2vC6gmc80eiWsABUyrSX2rCLnWmcKLyv1ZlJanI4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id QXcSraDwa80oiQZ3Yr0O5Y; Thu, 18 Jan 2024 20:32:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QZ3XrsCCbD6lhQZ3YrjjRb; Thu, 18 Jan 2024 20:32:08 +0000 X-Authority-Analysis: v=2.4 cv=LNR1/ba9 c=1 sm=1 tr=0 ts=65a98ac8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=MatczMKtvbaZHu8P7h8A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YNcx1GzvX3FKzUasaO8qaaD0Vs1LcqYGAKcrB5yG/po=; b=pdqFGqIT5wYWJwQyhhpxiDo2+X Ykq6eFVOeeRvDPpPh/JluoI5jl1TbcghpBcNe+eWF2wDWOPrbCN47+DQMjq2lk6FtTLwKYGoFDvTy pz9J84dIYNIlLhZr7TmUwjlw5; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:50746 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rQZ3X-002DCj-1z for gdb-patches@sourceware.org; Thu, 18 Jan 2024 13:32:07 -0700 From: Tom Tromey Date: Thu, 18 Jan 2024 13:32:01 -0700 Subject: [PATCH v2 03/30] Fix latent bug in DW_TAG_entry_point handling MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240118-submit-domain-hacks-2-v2-3-aecab29fa104@tromey.com> References: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> In-Reply-To: <20240118-submit-domain-hacks-2-v2-0-aecab29fa104@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQZ3X-002DCj-1z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net ([192.168.0.21]) [97.122.68.157]:50746 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfK6HHbqRzFgaLRp16yl4X52RCQF2etaMIE2G5c5yO35F3UNDs3m328RTgPbXu8Tbpa9+u6A3ociijw5OqmISZoc3bRfIF8IblFCsLsMOwJmZitWu2IhR 674oX9sWleDw1hxEKRUzC+W0tydYLDGq8+itXa/KPA0ledyD5ZtLNzp1+n+77aUhBFMGAXXfmcuSsX2Fcj29yiZw+0zsRAvVsVE= X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: A DW_TAG_entry_point symbol inherits its extern/static property from the enclosing subroutine. This is encoded in new_symbol -- but the cooked indexer does not agree. --- gdb/dwarf2/read.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index b55b208ff4b..a4b8a855e24 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -16526,6 +16526,13 @@ cooked_indexer::index_dies (cutu_reader *reader, info_ptr, abbrev, &name, &linkage_name, &flags, &sibling, &this_parent_entry, &defer, false); + /* A DW_TAG_entry_point inherits its static/extern property from + the enclosing subroutine. */ + if (abbrev->tag == DW_TAG_entry_point) + { + flags &= ~IS_STATIC; + flags |= parent_entry->flags & IS_STATIC; + } if (abbrev->tag == DW_TAG_namespace && m_language == language_cplus -- 2.43.0