From: "Alexandra Hájková" <ahajkova@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 4/6] gdbserver/linux-low.cc: Connect the inferior to the terminal
Date: Fri, 19 Jan 2024 12:56:28 +0100 [thread overview]
Message-ID: <20240119115659.491195-6-ahajkova@redhat.com> (raw)
In-Reply-To: <20240119115659.491195-1-ahajkova@redhat.com>
If GDBserver is connected to GDB via stdio and it recieved file
descriptors of the STDIN/OUT/ERR of the terminal GDB is connected to,
GDBserver will start the inferior connected to them.
---
gdbserver/linux-low.cc | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index dc3d2629fdb..2e91f00da24 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -954,6 +954,8 @@ linux_process_target::low_new_thread (lwp_info *info)
static void
linux_ptrace_fun ()
{
+ client_state &cs = get_client_state ();
+
if (ptrace (PTRACE_TRACEME, 0, (PTRACE_TYPE_ARG3) 0,
(PTRACE_TYPE_ARG4) 0) < 0)
trace_start_error_with_name ("ptrace");
@@ -961,10 +963,38 @@ linux_ptrace_fun ()
if (setpgid (0, 0) < 0)
trace_start_error_with_name ("setpgid");
+ /* If GDBserver is connected to GDB via stdio and it recieved the file
+ descriptors for the terminal stdin/out/err from GDB, start the inferior
+ connected to them. */
+ if (remote_connection_is_stdio () && cs.vDefaultInferiorFd_accepted)
+ {
+ struct stat buf{};
+
+ if ((fstat(cs.fds[0], &buf) == -1)
+ || (fstat(cs.fds[1], &buf) == -1)
+ || (fstat(cs.fds[2], &buf) == -1))
+ {
+ write (2, "Fstat failed. Can't connect inferior to the terminal.\n",
+ sizeof ("Fstat failed. Can't connect inferior to the terminal.\n") - 1);
+ cs.vDefaultInferiorFd_accepted = false;
+ }
+
+ /* Dupped file descriptors will be inherited by the inferior. */
+ if (!cs.vDefaultInferiorFd_accepted
+ || (dup2 (cs.fds[0], 0) == -1)
+ || (dup2 (cs.fds[1], 1) == -1)
+ || (dup2 (cs.fds[2], 2) == -1))
+ {
+ write (2, "Dup2 failed. Can't connect inferior to the terminal.\n",
+ sizeof ("Dup2 failed. Can't connect inferior to the terminal.\n") - 1);
+ cs.vDefaultInferiorFd_accepted = false;
+ }
+ }
+
/* If GDBserver is connected to gdb via stdio, redirect the inferior's
stdout to stderr so that inferior i/o doesn't corrupt the connection.
Also, redirect stdin to /dev/null. */
- if (remote_connection_is_stdio ())
+ if (remote_connection_is_stdio () && !cs.vDefaultInferiorFd_accepted)
{
if (close (0) < 0)
trace_start_error_with_name ("close");
--
2.43.0
next prev parent reply other threads:[~2024-01-19 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 11:56 [PATCH v2 0/6] Add vDefaultInferiorFd feature Alexandra Hájková
2024-01-19 11:56 ` [PATCH v2 1/6] gdb.server/non-existing-program.exp: Use gdbserver_start Alexandra Hájková
2024-01-19 11:56 ` [PATCH v2] remote.c: Make packet_check_result return a structure Alexandra Hájková
2024-02-22 14:37 ` Alexandra Petlanova Hajkova
2024-02-23 16:19 ` Tom Tromey
2024-01-19 11:56 ` [PATCH v2 2/6] gdb/ser-pipe.c: Duplicate the file descriptors Alexandra Hájková
2024-01-19 11:56 ` [PATCH v2 3/6] Add new vDefaultInferiorFd packet Alexandra Hájková
2024-01-19 12:04 ` Eli Zaretskii
2024-01-19 11:56 ` Alexandra Hájková [this message]
2024-01-19 11:56 ` [PATCH v2 5/6] remote.c: Add terminal handling functions Alexandra Hájková
2024-01-19 11:56 ` [PATCH v2 6/6] Add defaultinf.exp test to the testsuite Alexandra Hájková
2024-02-22 14:38 ` [PATCH v2 0/6] Add vDefaultInferiorFd feature Alexandra Petlanova Hajkova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119115659.491195-6-ahajkova@redhat.com \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).