From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7D3A63858C56 for ; Fri, 19 Jan 2024 22:34:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D3A63858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D3A63858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705703691; cv=none; b=BoEDhvJC5ASZjJwGi/rJGPiTVescGzakk7BhltS79ez8b1kYiIwZL2/c66fCfaFUjBbhotl2HTPM2xu7JFpt7UxXHk3ezxk0z05f+AnLlrY5WxJMxS4hPBXLiPHl2KX9w3mdew+ATEdOWanYhqK0pCvLcH7CIGbpAQqkAK+eHwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705703691; c=relaxed/simple; bh=lYeejvuxPTBEHm5/2kHINPAHHYoLDvK+2gfjz/X0ODo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=O/ADYUHJeoHC/K/g6GXdp/xLky3SCr1bsaZTzPF7vCBPMvbsIBm6ljhgmIMOOEQKMnkYejG8ChV/q0MeQgDToh/h9d4L2lB8dTE/lAes6z7zeRs2fJAv4QrSLiD1KEo/8FjNWzBmealHZqhjLXqeS5qnhok6xwLTa9YJtR+zWtc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705703672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=udPzvqTao/obUO006qWpktomS9J2ZR6BeH8ucaGZe6s=; b=SR4Zt4cQBrBNhdwp8uYxNGFpwNbGxqSSpHs5aw8zTi7h10uRAIB9x6Q7QytriKN9A1C4xu kw6Hba7qqfs15G5MkQk/wpJnmck+nD93DlcD0dgGdayz47uCNnJpAZ6QPAH80nzbe8llQr spcd7Psg70AMYTNRiff2cX2IzXKR15o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-2SYzVZd8MIiwV3IJ-7nnxw-1; Fri, 19 Jan 2024 17:34:30 -0500 X-MC-Unique: 2SYzVZd8MIiwV3IJ-7nnxw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F14183BA82; Fri, 19 Jan 2024 22:34:30 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB24540D1B60; Fri, 19 Jan 2024 22:34:29 +0000 (UTC) Date: Fri, 19 Jan 2024 15:34:28 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix handling of DW_OP_GNU_push_tls_address Message-ID: <20240119153428.0a6abd2d@f39-zbm-amd> In-Reply-To: <20240117122154.2880311-1-tromey@adacore.com> References: <20240117122154.2880311-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 17 Jan 2024 05:21:54 -0700 Tom Tromey wrote: > In one spot, DW_OP_GNU_push_tls_address is handled differently from > DW_OP_form_tls_address. However, I think they should always be > treated identically. I agree. Approved-by: Kevin Buettner