From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 75BA53858D3C for ; Fri, 19 Jan 2024 22:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75BA53858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 75BA53858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705704335; cv=none; b=ZaQ9sGKVGrkwH3lciHbAke+TUNzcbCNQzAK11EWdHgwubeqYP8fTYVenCFGkfxf0E1Gg5nJkwHsYGvNcvY9q+JL6fY6/qinhqzZbk7LOJpuTc92+OjONPpmC4GBn6pyD65TxbESH97T0C51thcNJYdHIqeJIsXcZHMlzMHC24gU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705704335; c=relaxed/simple; bh=rM1C2v7bmVb5nOUwuPKv+2zN6LYJxcCrtuV311W22sY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=pnR1OIVDpGC3OraGHuOff9Ug/o57f56JRZGuhI/ktLRLFYojhMqaP3iS9Z+XIUJGGLh1LSyEbVBAA38zqJzdqiw4RHB1TPMDA445mcj+SHpd4zaKDhTPzDQGiCUNbFXBuNagBjYd//4blxYPGdUUsAmIGQkCoHNDh0sWxCbdC6Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705704334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6h21aRKIDa7YEK9ctCR8/OJg7sjVoTlz6iMm6V13aIo=; b=gXu+Cn6oxgNrMbHtLH4S4a8/DTlITq5DDu6mcFqI0K0yxSkNOG5WLaLosdcXklt9FzXE/p 5Xfy1XoWBCLMcQwUgy5MVpqfg9wZzxJzSmTi6lwywCAqJpN0lh4T+pEbuBp9RHt9EYA0k9 kkUi/0FKFMznLHMyIRUkkrqExjli9C8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-mIBUSLeLO8WwcGiTMBv63g-1; Fri, 19 Jan 2024 17:45:31 -0500 X-MC-Unique: mIBUSLeLO8WwcGiTMBv63g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF9451064FA1; Fri, 19 Jan 2024 22:45:30 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58A2E1C02EB3; Fri, 19 Jan 2024 22:45:30 +0000 (UTC) Date: Fri, 19 Jan 2024 15:45:28 -0700 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: remove SYMBOL_*_OPS macros Message-ID: <20240119154528.4a023ea0@f39-zbm-amd> In-Reply-To: <20240119203246.83805-1-simon.marchi@efficios.com> References: <20240119203246.83805-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 19 Jan 2024 15:32:32 -0500 Simon Marchi wrote: > New in v2: > > - remove one use of auto in findvar.c > - fix formatting in frame.c > > Remove SYMBOL_BLOCK_OPS, SYMBOL_COMPUTED_OPS and SYMBOL_REGISTER_OPS, in > favor of methods on struct symbol. More changes could be done here to > improve the design and make things safer, but I just wanted to do a > straightforward change to remove the macros for now. LGTM. Reviewed-by: Kevin Buettner