public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>, Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH v2 12/14] Return void from tui_show_frame_info
Date: Sat, 20 Jan 2024 11:23:23 -0700	[thread overview]
Message-ID: <20240120-tui-regs-cleanup-v2-12-a3cccc6a3573@tromey.com> (raw)
In-Reply-To: <20240120-tui-regs-cleanup-v2-0-a3cccc6a3573@tromey.com>

Nothing uses the tui_show_frame_info result any more, so change it to
return void.

Tested-By: Tom de Vries <tdevries@suse.de>
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
---
 gdb/tui/tui-status.c | 16 ++++++----------
 gdb/tui/tui-status.h |  2 +-
 2 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/gdb/tui/tui-status.c b/gdb/tui/tui-status.c
index e61bf71c600..df4675fe5df 100644
--- a/gdb/tui/tui-status.c
+++ b/gdb/tui/tui-status.c
@@ -262,13 +262,11 @@ tui_status_window::rerender ()
   wmove (handle.get (), 0, 0);
 }
 
-/* Function to print the frame information for the TUI.  The windows are
-   refreshed only if frame information has changed since the last refresh.
+/* Function to print the frame information for the TUI.  The windows
+   are refreshed only if frame information has changed since the last
+   refresh.  */
 
-   Return true if frame information has changed (and windows
-   subsequently refreshed), false otherwise.  */
-
-bool
+void
 tui_show_frame_info (frame_info_ptr fi)
 {
   bool status_changed_p;
@@ -292,7 +290,7 @@ tui_show_frame_info (frame_info_ptr fi)
 	 not changed.  If frame information has not changed, then the windows'
 	 contents will not change.  So don't bother refreshing the windows.  */
       if (!status_changed_p)
-	return false;
+	return;
 
       for (struct tui_source_window_base *win_info : tui_source_windows ())
 	{
@@ -307,13 +305,11 @@ tui_show_frame_info (frame_info_ptr fi)
       status_changed_p = tui_location.set_location (NULL, sal, "");
 
       if (!status_changed_p)
-	return false;
+	return;
 
       for (struct tui_source_window_base *win_info : tui_source_windows ())
 	win_info->erase_source_content ();
     }
-
-  return true;
 }
 
 void
diff --git a/gdb/tui/tui-status.h b/gdb/tui/tui-status.h
index 4a0f59a2eaa..efef5375e86 100644
--- a/gdb/tui/tui-status.h
+++ b/gdb/tui/tui-status.h
@@ -51,6 +51,6 @@ struct tui_status_window
 };
 
 extern void tui_show_status_content (void);
-extern bool tui_show_frame_info (frame_info_ptr);
+extern void tui_show_frame_info (frame_info_ptr);
 
 #endif /* TUI_TUI_STATUS_H */

-- 
2.43.0


  parent reply	other threads:[~2024-01-20 18:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20 18:23 [PATCH v2 00/14] Cleanups for the TUi register window Tom Tromey
2024-01-20 18:23 ` [PATCH v2 01/14] Use pop_back in tui_register_format Tom Tromey
2024-01-20 18:23 ` [PATCH v2 02/14] Minor C++ cleanups in tui-regs.c Tom Tromey
2024-01-20 18:23 ` [PATCH v2 03/14] Simplify tui_data_window::show_register_group Tom Tromey
2024-01-20 18:23 ` [PATCH v2 04/14] Rename tui_data_item_window -> tui_register_info Tom Tromey
2024-01-20 18:23 ` [PATCH v2 05/14] Change tui_register_info::visible to a method Tom Tromey
2024-01-20 18:23 ` [PATCH v2 06/14] Move scrollok call in register window Tom Tromey
2024-01-20 18:23 ` [PATCH v2 07/14] Simplify update_register_data Tom Tromey
2024-01-20 18:23 ` [PATCH v2 08/14] Remove the TUI register window rerender overload Tom Tromey
2024-02-08 11:18   ` Andrew Burgess
2024-01-20 18:23 ` [PATCH v2 09/14] Simplify tui_data_win::erase_data_content Tom Tromey
2024-02-08 11:22   ` Andrew Burgess
2024-02-08 19:19     ` Tom Tromey
2024-01-20 18:23 ` [PATCH v2 10/14] Remove tui_refreshing_registers Tom Tromey
2024-01-20 18:23 ` [PATCH v2 11/14] Remove redundant check from tui_refresh_frame_and_register_information Tom Tromey
2024-01-20 18:23 ` Tom Tromey [this message]
2024-01-20 18:23 ` [PATCH v2 13/14] Rename show_registers -> set_register_group Tom Tromey
2024-01-20 18:23 ` [PATCH v2 14/14] Update TUI register window when the inferior exits Tom Tromey
2024-02-08 11:37 ` [PATCH v2 00/14] Cleanups for the TUi register window Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240120-tui-regs-cleanup-v2-12-a3cccc6a3573@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).