From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 2B7693858D38 for ; Wed, 24 Jan 2024 15:48:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B7693858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2B7693858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706111336; cv=none; b=Bx8HuGGwhQFgoTHbuUUZq7mBPiL9A8Le8u6RPWPNShJ3WLLjk9gTNdbSEfTYR/QW3Rs893n046nyGB5wU0WeiBjlKe58Ss5/5U36OkA0Hqn1qxKIiI1if4SPY01wosoXHMVj1WSY8IKNRxUAsc1ZuIhNxJlynSae+vBjAexuG4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706111336; c=relaxed/simple; bh=Jy6TPE9PLm/wDufAQKJEZO+oKalo42t9s6TVsRZzEGc=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=qUSM2EEi/+FDlT1Gn3zOuMaow3X08r4BRqLcRWIjL/2PytAw83aixR805/5tkqKYsGxpLaDsysXfPxQ8rOul7rPwr6QAiShqWbvadZ0KhM3E5vCfIZaxDLFoQW5ZXGoFLPMr4fFfXhlGCwAV30VWWIgiHMYkkdrPu9B4AkYEL4M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7bb5fda069bso295461539f.0 for ; Wed, 24 Jan 2024 07:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1706111334; x=1706716134; darn=sourceware.org; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:from:to:cc:subject:date:message-id:reply-to; bh=Lt1fY8Xmw/riZl4HyDvjyFOrdcbdGuUNwPvso53kcts=; b=RR9lyhoGPr76jdu4Xk5/Sa/EU6r9/GbGSkY/WfD5MSqoSyHk/EXYmC8lql4NeGHiix NpyEUsM3D0h1PjHFCPqmmOWnAck+YM7hv/WSo3g/GDAaPqL2Hb+rd8e1Kpx9VaeneByO uf5NdcVvJghduopifom+uiqFYJRdGW3Kfixn1R47vK1PHPxvrks7VtYj4VEZDrJtSLyI b1+F402FGLXm5mJqX49HAO1r35QJR7K0Rwexvjba5Zql88C9noZIcxUmT91w6DWihMyv nqcC7b4fx5FWiUpnVsfAGvfsgU/2BnK4sy42QpeFLBFaRJUNZmrDS4XnfwmhYFTKFgMI yEfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706111334; x=1706716134; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lt1fY8Xmw/riZl4HyDvjyFOrdcbdGuUNwPvso53kcts=; b=mUR4Nu+/D+JOgLd1v7jutooszJOLFyLa1rpkABmbocy5c/yqgZJ9G0wNiKTe9ZEKOe 4DMcIxDrZZE4P+zI3xQ1gpF93eEw2RHejfQPRzhOMcytDk2uam+glHYJEJ5nQA3+UR0P NnMFudjlob/nMyujB72Da1cvEKFsGPRLdDS9dmvPL3Tg9sY0NbZo3MjuDi648f4UnT00 GRm5jF6/NnlK+W9lxF0lSiAgjgU76+ADvmB5BHXec2y7FtKKFvCwNiqkfedsExeqmUbC U0DCILmDHNmRi/Gxe2ThnVptBOPvG3VfUZ+Ng4Scx5G0Yt/dTNSE/HMpv1pCexVpwmB0 xzKw== X-Gm-Message-State: AOJu0Ywe/jzuVJJNeH/GbcK4VQJKDYmnk/GKWp/HR+TXpmn8UTxJlK1/ dAIzN7010Z66ycxsgu8pb5f5j2xrQqMGIozod5+1aCMtlW3u954kC3z6vMDvofyEOfxpkUNiqgw = X-Google-Smtp-Source: AGHT+IF6B5r46r7egVHotET+CChtB2rzQfuS7qhEho2ovjQ6KSYEr6p9Ym2x8H7K4C9sJWLQEqz2dA== X-Received: by 2002:a5e:9746:0:b0:7ba:85e4:f8de with SMTP id h6-20020a5e9746000000b007ba85e4f8demr1755953ioq.42.1706111334345; Wed, 24 Jan 2024 07:48:54 -0800 (PST) Received: from localhost.localdomain (97-122-68-157.hlrn.qwest.net. [97.122.68.157]) by smtp.gmail.com with ESMTPSA id h5-20020a6b7845000000b007ba783a27c3sm6972526iop.11.2024.01.24.07.48.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 07:48:53 -0800 (PST) From: Tom Tromey Subject: [PATCH 0/3] Fix ordering of configurationDone and launch Date: Wed, 24 Jan 2024 08:48:52 -0700 Message-Id: <20240124-dap-launch-fix-v1-0-0d47f87fa9f0@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAGQxsWUC/x2MQQqDQAxFryJZN6DTYZRepXQRx1gDdiqJSkG8e 9Mu3+e/d4CxChvcqgOUdzF5F4fmUkGeqDwZZXCGUIdYNyHiQAvOtJU84SgfTGOk3KZrG7oELi3 KPv+D94dzT8bYK/n/l3mRraxwnl8sY30HeQAAAA== To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This series is really just a couple of small preparatory patches before patch #3, where the problem is described. Anyway, gdb's implementation of 'launch' is wrong -- it should really start the inferior. DAP, somewhat bizarrely IMO, wants the client to set breakpoints and such before the debugger knows what executable to use. This series fixes gdb to follow the spec here. --- Tom Tromey (3): Export dap_initialize Clean up suppress_new_breakpoint_event Fix DAP launch and configurationDone requests gdb/python/lib/gdb/dap/breakpoint.py | 135 ++++++++++++++++-------------- gdb/python/lib/gdb/dap/launch.py | 29 ++----- gdb/testsuite/gdb.dap/ada-arrays.exp | 8 +- gdb/testsuite/gdb.dap/ada-nested.exp | 7 +- gdb/testsuite/gdb.dap/ada-scopes.exp | 7 +- gdb/testsuite/gdb.dap/args-env.exp | 8 +- gdb/testsuite/gdb.dap/assign.exp | 7 +- gdb/testsuite/gdb.dap/basic-dap.exp | 63 +++++++------- gdb/testsuite/gdb.dap/bt-nodebug.exp | 8 +- gdb/testsuite/gdb.dap/catch-exception.exp | 7 +- gdb/testsuite/gdb.dap/children.exp | 7 +- gdb/testsuite/gdb.dap/cond-bp.exp | 16 +++- gdb/testsuite/gdb.dap/cwd.exp | 7 +- gdb/testsuite/gdb.dap/cxx-exception.exp | 7 +- gdb/testsuite/gdb.dap/eof.exp | 2 +- gdb/testsuite/gdb.dap/frameless.exp | 9 +- gdb/testsuite/gdb.dap/hover.exp | 8 +- gdb/testsuite/gdb.dap/lazy-string.exp | 7 +- gdb/testsuite/gdb.dap/log-message.exp | 8 +- gdb/testsuite/gdb.dap/memory.exp | 8 +- gdb/testsuite/gdb.dap/modules.exp | 7 +- gdb/testsuite/gdb.dap/pause.exp | 8 +- gdb/testsuite/gdb.dap/ptrref.exp | 8 +- gdb/testsuite/gdb.dap/rust-slices.exp | 8 +- gdb/testsuite/gdb.dap/scopes.exp | 8 +- gdb/testsuite/gdb.dap/sources.exp | 4 + gdb/testsuite/gdb.dap/stack-format.exp | 7 +- gdb/testsuite/gdb.dap/stop-at-main.exp | 6 +- gdb/testsuite/gdb.dap/terminate.exp | 6 +- gdb/testsuite/lib/dap-support.exp | 25 +++--- 30 files changed, 260 insertions(+), 185 deletions(-) --- base-commit: 7737b1336402cd4682538620ab996bdb7ad0ea79 change-id: 20240124-dap-launch-fix-6f4ac7637286 Best regards, -- Tom Tromey