public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/3] Export dap_initialize
Date: Wed, 24 Jan 2024 08:48:53 -0700	[thread overview]
Message-ID: <20240124-dap-launch-fix-v1-1-0d47f87fa9f0@adacore.com> (raw)
In-Reply-To: <20240124-dap-launch-fix-v1-0-0d47f87fa9f0@adacore.com>

This changes the test suite to export dap_initialize.
---
 gdb/testsuite/lib/dap-support.exp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp
index 0bb413e4037..07259862b18 100644
--- a/gdb/testsuite/lib/dap-support.exp
+++ b/gdb/testsuite/lib/dap-support.exp
@@ -238,7 +238,7 @@ proc dap_check_request_and_response {name command {obj {}}} {
 # desired.  Callers not caring about this should probably use
 # dap_launch.  Returns the empty string on failure.  NAME is used as
 # the test name.
-proc _dap_initialize {name} {
+proc dap_initialize {name} {
     if {[dap_gdb_start]} {
 	return ""
     }
@@ -266,7 +266,7 @@ proc _dap_initialize {name} {
 # After this proc is called, gdb will be ready to accept breakpoint
 # requests.
 proc dap_launch {file {args {}}} {
-    if {[_dap_initialize "startup - initialize"] == ""} {
+    if {[dap_initialize "startup - initialize"] == ""} {
 	return ""
     }
     set params "o program"
@@ -315,7 +315,7 @@ proc dap_launch {file {args {}}} {
 # specifying PID as the inferior process ID.  Returns the empty string
 # on failure, or the response object from the attach request.
 proc dap_attach {pid {prog ""}} {
-    if {[_dap_initialize "startup - initialize"] == ""} {
+    if {[dap_initialize "startup - initialize"] == ""} {
 	return ""
     }
 
@@ -331,7 +331,7 @@ proc dap_attach {pid {prog ""}} {
 # specifying TARGET as the remote target.  Returns the empty string on
 # failure, or the response object from the attach request.
 proc dap_target_remote {target} {
-    if {[_dap_initialize "startup - initialize"] == ""} {
+    if {[dap_initialize "startup - initialize"] == ""} {
 	return ""
     }
     return [dap_check_request_and_response "startup - target" attach \

-- 
2.43.0


  reply	other threads:[~2024-01-24 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 15:48 [PATCH 0/3] Fix ordering of configurationDone and launch Tom Tromey
2024-01-24 15:48 ` Tom Tromey [this message]
2024-01-24 15:48 ` [PATCH 2/3] Clean up suppress_new_breakpoint_event Tom Tromey
2024-01-24 15:48 ` [PATCH 3/3] Fix DAP launch and configurationDone requests Tom Tromey
2024-02-12 17:41 ` [PATCH 0/3] Fix ordering of configurationDone and launch Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124-dap-launch-fix-v1-1-0d47f87fa9f0@adacore.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).