From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 329FB3858D37 for ; Thu, 25 Jan 2024 14:19:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 329FB3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 329FB3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706192398; cv=none; b=PDtnnJzQJXMjUuYijACYOmiE9h1FNmpYEXSvPvbOD69vgE5ne8GLUmLd5MN78qbj8+bAD3fePauy4ypEU7s8nHRM0kEBdM3kSxciQELEX7CucBD+tgvWV5WLVRPfN3N4XVZym+09kc70CSwVTXuSQUWBe4t0cknTpS0HT+JquyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706192398; c=relaxed/simple; bh=WzMiMak4qI/NT4bVdfSEvTCC8M6t0Clu5Eyh+8q16xw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=F5ylB3c64OB1EzJ8sgK+3EriHRE7K2YRwFwqcC2OKs2nd6xArnjO8ZXRkRuKCkWG9aelWvc8J21shZp1HSZtMCr/lTcviTfHMRqdyQ2XS9KoQxUGh/l44tq4Z7ytHoQ2PkRBhaCcjYe5/YUwq7uI7dm0k47dIGhmHXAlTShMhgo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C94161F898 for ; Thu, 25 Jan 2024 14:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706192391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2kmIHJ2tkkBEWEnMobfJ7GiQBOwE2utey/27aDoDxak=; b=sIgaUWnj3teuVwS6IN85O0kanXAV/12Z7PYtK9FkvGMPy03MxfBNbydn58OWXuaj7+FXgJ iFkce/3ChrbbepnhoNdvgmymJ1svOG6WaZSUuFBHHpH35pZrn0knLZq6M4gnGUgYZTHkBm 5ZXCYLUN2v0tvzznxdpDlkoy6NBQo1A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706192391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2kmIHJ2tkkBEWEnMobfJ7GiQBOwE2utey/27aDoDxak=; b=eU7kDlBvtUHkC00envX6Lj8p8kL+bAeamTutiT3XDmIZIV/kQRAOu/QOPALZPOf/zvN+lo itveT5d10oFap9AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706192390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2kmIHJ2tkkBEWEnMobfJ7GiQBOwE2utey/27aDoDxak=; b=SuUY/N9GPFNA7FptbdenHgKtCNbMZvzp1/jKxPZN1xuGPEnH/trDKQ4r/ZPCLQpnERC600 JxykoCnh5ZsvtlduzA0ZuEzQJEwSc6fYVUj+lQG5/KxS3tm/1uDlhxuz5cmM/2wsOuHh47 vve58S2DhV9lliHF/2vcrH1wa096AL0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706192390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2kmIHJ2tkkBEWEnMobfJ7GiQBOwE2utey/27aDoDxak=; b=VCYdxMkZLgFfGf++BLuEePpIs8slvMRBwtW2l/jtIsNieI/3ePXYZNmbTu5dv62F9ARtvY lQqh/DhJJV1XRGAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B1F5E13649 for ; Thu, 25 Jan 2024 14:19:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 10EwKgZusmVyTgAAD6G6ig (envelope-from ) for ; Thu, 25 Jan 2024 14:19:50 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/build] Workaround gcc PR113599 Date: Thu, 25 Jan 2024 15:21:07 +0100 Message-Id: <20240125142107.8643-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Score: 3.69 X-Spamd-Result: default: False [3.69 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.01)[50.42%] X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Since gcc commit d3f48f68227 ("c++: non-dependent .* operand folding [PR112427]"), with gdb we run into PR gcc/113599 [1], a wrong-code bug, as reported in PR build/31281. Work around this by flipping inherit order: ... -class thread_info : public refcounted_object, - public intrusive_list_node +class thread_info : public intrusive_list_node, + public refcounted_object ... An argument could be made that this isn't necessary, because this occurred in an unreleased gcc version. However, I think it could be useful when bisecting gcc for other problems in building gdb. Having this workaround means the bisect won't reintroduce the problem. Furthermore, the workaround is harmless. Tested on Fedora rawhide x86_64. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31281 [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113599 --- gdb/gdbthread.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h index e7035d40ad4..1d9730fd1fa 100644 --- a/gdb/gdbthread.h +++ b/gdb/gdbthread.h @@ -244,10 +244,11 @@ using private_thread_info_up = std::unique_ptr; strong reference, and is thus not accounted for in the thread's refcount. - The intrusive_list_node base links threads in a per-inferior list. */ + The intrusive_list_node base links threads in a per-inferior list. + We place it first in the inherit orer to work around PR gcc/113599. */ -class thread_info : public refcounted_object, - public intrusive_list_node +class thread_info : public intrusive_list_node, + public refcounted_object { public: explicit thread_info (inferior *inf, ptid_t ptid); base-commit: 726f209eb1b05842d816eac8b0b8f9c7f6cd9fbc -- 2.35.3