From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default
Date: Sat, 3 Feb 2024 00:14:08 -0300 [thread overview]
Message-ID: <20240203031408.137939-1-thiago.bauermann@linaro.org> (raw)
Commit e5f2f7d901ee ("Disable year 2038 support on 32-bit hosts by
default") fixed a mismatch between 64-bit time_t in GDB and system headers
and 32-bit time_t in BFD.
However, since commit 862776f26a59 ("Finalized intl-update patches")
gnulib's year 2038 support has been accidentally re-enabled — causing
problems for 32-bit hosts again. The commit split baseargs into
{h,b}baseargs, but this hasn't been done for the code that handles
--disable-year2038.
This patch restores the intended behaviour. With this change, the number
of unexpected core files goes from 18 to 4.
Tested on armv8l-linux-gnueabihf.
---
configure | 3 ++-
configure.ac | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 670684d83d15..6466b97f3ec0 100755
--- a/configure
+++ b/configure
@@ -10313,7 +10313,8 @@ hbaseargs="$hbaseargs --disable-option-checking"
tbaseargs="$tbaseargs --disable-option-checking"
if test "$enable_year2038" = no; then
- baseargs="$baseargs --disable-year2038"
+ bbaseargs="$bbaseargs --disable-year2038"
+ hbaseargs="$hbaseargs --disable-year2038"
tbaseargs="$tbaseargs --disable-year2038"
fi
diff --git a/configure.ac b/configure.ac
index 88b4800e298f..1300a805fd8d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3432,7 +3432,8 @@ hbaseargs="$hbaseargs --disable-option-checking"
tbaseargs="$tbaseargs --disable-option-checking"
if test "$enable_year2038" = no; then
- baseargs="$baseargs --disable-year2038"
+ bbaseargs="$bbaseargs --disable-year2038"
+ hbaseargs="$hbaseargs --disable-year2038"
tbaseargs="$tbaseargs --disable-year2038"
fi
next reply other threads:[~2024-02-03 3:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 3:14 Thiago Jung Bauermann [this message]
2024-02-03 16:39 ` Thiago Jung Bauermann
2024-02-06 8:26 ` Mark Wielaard
2024-02-05 14:59 ` Luis Machado
2024-02-05 17:25 ` Thiago Jung Bauermann
2024-02-05 18:39 ` Thiago Jung Bauermann
2024-02-05 18:57 ` Andrew Pinski
2024-02-06 20:57 ` Thiago Jung Bauermann
2024-02-05 18:48 ` Thiago Jung Bauermann
2024-02-05 20:24 ` Tom Tromey
2024-02-06 21:39 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240203031408.137939-1-thiago.bauermann@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).