From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Don't allow multiple request registrations in DAP
Date: Wed, 7 Feb 2024 12:47:35 -0700 [thread overview]
Message-ID: <20240207194735.3478872-1-tromey@adacore.com> (raw)
This changes the DAP code to check that a given request or capability
is only registered a single time. This is just a precaution against
accidentally introducing a second definition of a request somewhere.
---
gdb/python/lib/gdb/dap/server.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/python/lib/gdb/dap/server.py b/gdb/python/lib/gdb/dap/server.py
index 7cc5a4681ee..ba139412b90 100644
--- a/gdb/python/lib/gdb/dap/server.py
+++ b/gdb/python/lib/gdb/dap/server.py
@@ -354,6 +354,7 @@ def request(
cmd = _check_not_running(cmd)
global _commands
+ assert name not in _commands
_commands[name] = cmd
return cmd
@@ -366,6 +367,7 @@ def capability(name, value=True):
def wrap(func):
global _capabilities
+ assert name not in _capabilities
_capabilities[name] = value
return func
--
2.43.0
next reply other threads:[~2024-02-07 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 19:47 Tom Tromey [this message]
2024-02-09 12:04 ` Alexandra Petlanova Hajkova
2024-02-21 21:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207194735.3478872-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).