From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 44D213858D38 for ; Mon, 12 Feb 2024 14:54:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44D213858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 44D213858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707749698; cv=none; b=kOIrAvyoubq+u/mh4WuuhU3feM7dPDtZBH+lKsjclwqSZC2t18PFu1DaetAG5Jms9Zk4g3ZUrw1Ol3u23UMa76KTkPp/wTLSQOdcrx3Nhu9d8k+DX3WMTFOHHjWr6dXWNuxBhcKB0SaKmmC5v/wHLi7EB24yZMl14yzcSO+mIo4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707749698; c=relaxed/simple; bh=QXr8HqDLrNtgIAiXHmM9Eqkx6gWZUrJDmWWsibWe2LQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=h9hjmwTe+doDVMgK0dQjQ1N2vfJN93yTVcrmYlfqvpxAZz+F34e9e4tD6zT9h09zXVXJfJhTbW/+F0SF3avSoaz0lAy5SrzXpZTbmqaUDcR19UZ4Y4w+HMNNyJohQyuFdp/DL4JvTBSiHiMunU3gyL6Zfs8NszpS3jYIRZvfesg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2BC691F787 for ; Mon, 12 Feb 2024 14:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707749695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvs6rF5jxdQhpYcGS5HsAka9uWUF+zPXOCxioqoh1hw=; b=SuS8V+XTYkIJ80Uq1U7rR1d5n7ZhxOzk7QcgkGdWI1Zbd3hNfFW0P0Us6ZH4rpKZkeOxrS v8wQ9EDy9EpsC09a5jQuUNdQeG3ZnMrXNeGu2+gSUnMfv65LD/+MqUwWOltM7QjiS/aDhX 75IAxZHAwhqQb0OSS0lrtjsCaQ+WUQc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707749695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvs6rF5jxdQhpYcGS5HsAka9uWUF+zPXOCxioqoh1hw=; b=EghBOdVR0h5m1F8n1qgZweL+dWg+HzKuYivdKOMp+AwhUIE5ZzydycA2fcjKJlilbmXvBd iYy+20BKQ/CoZNAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707749695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvs6rF5jxdQhpYcGS5HsAka9uWUF+zPXOCxioqoh1hw=; b=SuS8V+XTYkIJ80Uq1U7rR1d5n7ZhxOzk7QcgkGdWI1Zbd3hNfFW0P0Us6ZH4rpKZkeOxrS v8wQ9EDy9EpsC09a5jQuUNdQeG3ZnMrXNeGu2+gSUnMfv65LD/+MqUwWOltM7QjiS/aDhX 75IAxZHAwhqQb0OSS0lrtjsCaQ+WUQc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707749695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wvs6rF5jxdQhpYcGS5HsAka9uWUF+zPXOCxioqoh1hw=; b=EghBOdVR0h5m1F8n1qgZweL+dWg+HzKuYivdKOMp+AwhUIE5ZzydycA2fcjKJlilbmXvBd iYy+20BKQ/CoZNAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1501512FF7 for ; Mon, 12 Feb 2024 14:54:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id lTbEAz8xymXxWgAAD6G6ig (envelope-from ) for ; Mon, 12 Feb 2024 14:54:55 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb] Fix "value is not available" with debug frame Date: Mon, 12 Feb 2024 15:55:05 +0100 Message-Id: <20240212145505.32006-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SuS8V+XT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=EghBOdVR X-Spamd-Result: default: False [-0.31 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -0.31 X-Rspamd-Queue-Id: 2BC691F787 X-Spam-Level: X-Spamd-Bar: / X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On arm-linux, with a started hello world, running "info frame" works fine, but when I set debug frame to on, I run into: ... (gdb) info frame ... [frame] frame_unwind_register_value: exit value is not available (gdb) ... The problem is here in frame_unwind_register_value: ... if (value->lazy ()) gdb_printf (&debug_file, " lazy"); else { int i; gdb::array_view buf = value->contents (); ... where we call value->contents () while !value->entirely_available (). Fix this by checking value->entirely_available () and printing: ... [frame] frame_unwind_register_value: -> register=91 unavailable ... Tested on arm-linux. PR gdb/31369 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31369 --- gdb/frame.c | 2 ++ gdb/testsuite/gdb.base/debug-frame.exp | 42 ++++++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 gdb/testsuite/gdb.base/debug-frame.exp diff --git a/gdb/frame.c b/gdb/frame.c index 72a34fcfedc..7060a2d00ec 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -1314,6 +1314,8 @@ frame_unwind_register_value (frame_info_ptr next_frame, int regnum) if (value->lazy ()) gdb_printf (&debug_file, " lazy"); + else if (!value->entirely_available ()) + gdb_printf (&debug_file, " unavailable"); else { int i; diff --git a/gdb/testsuite/gdb.base/debug-frame.exp b/gdb/testsuite/gdb.base/debug-frame.exp new file mode 100644 index 00000000000..99511ee820c --- /dev/null +++ b/gdb/testsuite/gdb.base/debug-frame.exp @@ -0,0 +1,42 @@ +# Copyright 2024 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test relies on checking gdb debug output. Do not run if gdb debug is +# enabled as any debug will be redirected to the log. +require !gdb_debug_enabled + +standard_testfile main.c + +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug}]} { + return -1 +} + +if ![runto_main] { + return -1 +} + +# Redirect debug output to file. +set logfile [host_standard_output_file gdb.txt] +gdb_test_no_output "set logging file $logfile" \ + "set logging file [file tail $logfile]" +gdb_test_no_output "set logging debugredirect on" +gdb_test "set logging enabled on" + +# Enable debug frame. +gdb_test "set debug frame 1" + +# Check that calling info frame doesn't trigger an exception that escapes to +# the CLI. +gdb_test "info frame" "\r\n Saved registers:(\r\n \[^\r\n\]+ at $hex)*" base-commit: 60fed2e57f0219da68ecac3d13d590040f639c67 -- 2.35.3