From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 7FC063858C60 for ; Tue, 13 Feb 2024 10:08:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FC063858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FC063858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707818922; cv=none; b=UMtemCODpc5HRAvdz/Ta51XEcLKaaTkQJd+R6pj5/QsOc4rZtfK5VQE632fd7U9RArIbwexrrp2+M3UtqOi/DO/BRAO7Rj0rdj0wq8qTGVVQhmLKd258oi4iCISRlJVWrPmVaWCgTUzCw+C38WCWEeLh7alz0XT5uarNIFc2hlg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707818922; c=relaxed/simple; bh=i/5suxUeoE6yNJXZ+fhFmRficXb/HDXdlDAu5GBjlZc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=MoSomqqV1J9i/dzrEm2QdTygNzfOGn6xlUxuvFNeedJeLFDa06K17jW3yl3MKR9WZu0cUG9Dy+QR+4CD8tzXDltPYp4OgN/ZFnw5DlhF4JiKY7gwtMwzNDKlGZExAH20yUkN2jOso5Qz0RQQhhsv3Ak/G3vCHRKuG8AzXpuID3w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 535F3221C2; Tue, 13 Feb 2024 10:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707818919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zchnTs5D+eS9Kt7OwGJ8bOxXzpp+TyBO+U4AKTS0mb4=; b=GaVhAd8TTts3rIvHZeT05S9cPiSBbRLi5Zg1qliTXlhCjoTn+Yx/K6yRbS+HLlIwnV0vJ2 f+W36EXDhQUnZbrNdqi3zYHp6DJCC18TI7DAHc7uJGbSwKX4qvvqZVRGu0GclFIS8ikP1+ 5ycJ74VkZ/wQ+vd9SKjzLUQjswNK8TE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707818919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zchnTs5D+eS9Kt7OwGJ8bOxXzpp+TyBO+U4AKTS0mb4=; b=JYSJ8eg0C5uKjFmnLLEKGuXRUr31moML7JIwkOOuOFMFI+KNRzx0I6f+EpvAueuhK5PbI7 50eJRTaag+tpsSDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707818919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zchnTs5D+eS9Kt7OwGJ8bOxXzpp+TyBO+U4AKTS0mb4=; b=GaVhAd8TTts3rIvHZeT05S9cPiSBbRLi5Zg1qliTXlhCjoTn+Yx/K6yRbS+HLlIwnV0vJ2 f+W36EXDhQUnZbrNdqi3zYHp6DJCC18TI7DAHc7uJGbSwKX4qvvqZVRGu0GclFIS8ikP1+ 5ycJ74VkZ/wQ+vd9SKjzLUQjswNK8TE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707818919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zchnTs5D+eS9Kt7OwGJ8bOxXzpp+TyBO+U4AKTS0mb4=; b=JYSJ8eg0C5uKjFmnLLEKGuXRUr31moML7JIwkOOuOFMFI+KNRzx0I6f+EpvAueuhK5PbI7 50eJRTaag+tpsSDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 37E8F1370C; Tue, 13 Feb 2024 10:08:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QbQ+DKc/y2UqZAAAD6G6ig (envelope-from ); Tue, 13 Feb 2024 10:08:39 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] [gdb/testsuite] Fix fail in gdb.dap/sources.exp Date: Tue, 13 Feb 2024 11:08:51 +0100 Message-Id: <20240213100851.7979-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 3.70 X-Spamd-Result: default: False [3.70 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; BROKEN_CONTENT_TYPE(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[39.71%] X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: With test-case gdb.dap/sources.exp, I run into: ... {"request_seq": 4, "type": "response", "command": "source", \ "success": false, "message": "notStopped", \ "seq": 11}FAIL: gdb.dap/sources.exp: get source success ... The fail happens because the request races with the stopping at main as requested by: ... if {[dap_launch $testfile stop_at_main 1] == ""} { ... Fix this by waiting for the stop, in the same way that is done in other test-cases that use stop_at_main. Tested on x86_64-linux. PR testsuite/31374 https://sourceware.org/bugzilla/show_bug.cgi?id=31374 --- gdb/testsuite/gdb.dap/sources.exp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/testsuite/gdb.dap/sources.exp b/gdb/testsuite/gdb.dap/sources.exp index f601190d6f5..9b56337e5a8 100644 --- a/gdb/testsuite/gdb.dap/sources.exp +++ b/gdb/testsuite/gdb.dap/sources.exp @@ -46,6 +46,9 @@ if {$path == ""} { } else { pass "sources.c in loadedSources" + dap_wait_for_event_and_check "stopped at function breakpoint" stopped \ + "body reason" breakpoint + set obj [dap_check_request_and_response "get source" source \ [format {o source [o path [s %s]] \ sourceReference [i 0]} $path]] base-commit: 4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda -- 2.35.3