From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 7B37D3857B86 for ; Fri, 16 Feb 2024 18:37:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B37D3857B86 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B37D3857B86 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708108675; cv=none; b=e7BzFpd1ULFlR32VG9QY8G5IcvIP7yl8YXYExkFsydpndDiGfdrik7X22rhHvh13dL2LdJ8lM/XGXPGkBkbboCDM8Xmbq/3NspjYtdo9awRcgcFbDMsyHOILXWyW9zRXo+poLSDQgIRZolVZpdl0bZsvqu4Ia5tI+cZcmuRnm48= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708108675; c=relaxed/simple; bh=IVLDgjYF6AO7UyLVgTsCCLMgseMbqKPR4J2zuG+N9ws=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=ho7wPkxL661JW7JTqavot1o8EW3eXtX5YCR3t1+u6JD/YDK/nqVmrE39gFM+loi4dzjkwvDLYjfNg9yivbqhLpd69cOgp6offrZfJr/MKG9/Y41YSu/wZ7OK6q/vjjz9vB3c6prpOpr9Ku4Y23VtTWPq8Mkq8rdcV8lxQvFVvFY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x134.google.com with SMTP id e9e14a558f8ab-364f8246c8cso5686765ab.2 for ; Fri, 16 Feb 2024 10:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1708108672; x=1708713472; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=W08w9mDsW/if1berqk2+vmt/mY1riIPKEc3f7BmYuMQ=; b=StMwmPPFRgwn9hpDdiPG3JyiK5xXcJ2Qnzd71Ggf7A06GH04UNv1Vz8RQ8EKI/Gsjx +Hd5B4LHqf9AV29HS4DjcGNM4rcI5OlfcljuB1xCzBMqUW9j3BLvAEHw3496zLbqBkzt MwkrdgOAS/DxoiDUDz4GkgCKZ9CrVA/HFP+xsMXqmB19T7eNZF4HqbcYTjkiEnYj1A3Q V2XpjIixnf6dd8fQoEqpERGXuhxYMLxAu94hQBweM7pqyXB1U3UUgF6y8FFzHczKziCF v4MX/TRJqRWh7y/jeSN4TVpD4C5P6dsJiWbRi3UT/y3f7ogeHhjrtDw+l/cnl2iHGpNY z5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708108672; x=1708713472; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W08w9mDsW/if1berqk2+vmt/mY1riIPKEc3f7BmYuMQ=; b=w1Pr8DTkaP9EqhN1iDJTbUWz0IdLX/EWeJUcZbD/uYnohjdoQLwOi6SNbJMTrhQimZ kYUsooa5ljm//MCIcUIUJvfOQIvGFMH1bcecd9Nkbip4pLZxwuj2xQBUD1q8Q/3aJQRW ZoacxTruYQnBILCfUwc8N3ysUbsBgaPXBrQBYwsnKr6PahqPR/II+5d/FHvplrdtl7oT oZkQlMyRmp56IUF006V2Q2qqWP63hLVeylTI5R/zLP28pmAlTuoo/EeNzww175EDbxvM nhtNoTUC/PXdDGgcD16b2xEwA/5NRcvCUztdbysnj2f/ZXN1ob09Mhv1bl6H1VwfNvyQ BOBQ== X-Gm-Message-State: AOJu0Yzlmlt2tSNU3pt1YbWduX2Yal0Z46nvKZUOzBhKyYYdjuq29c5g otYADynaOHjb00d7dUGa+Mf811wRkwTDLUgPNgOnC40MrvZYZ4hAqth+v93UuN9nvPYDP2BL9oY = X-Google-Smtp-Source: AGHT+IHkk9IlNwQAnl2oC0tU9DV1Gls+7n8BbXWMef4gYWSnIWTSTiv1ksgrNtaOkdutab3+aXlwNg== X-Received: by 2002:a05:6e02:198b:b0:364:2238:732a with SMTP id g11-20020a056e02198b00b003642238732amr7841258ilf.25.1708108672650; Fri, 16 Feb 2024 10:37:52 -0800 (PST) Received: from localhost.localdomain (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id g20-20020a0566380bd400b00473eb9f9afcsm104724jad.61.2024.02.16.10.37.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 10:37:52 -0800 (PST) From: Tom Tromey Date: Fri, 16 Feb 2024 11:37:51 -0700 Subject: [PATCH 3/5] kfail a FinishBreakpoint test MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240216-py-simple-exc-v1-3-c275bcfb5e4a@adacore.com> References: <20240216-py-simple-exc-v1-0-c275bcfb5e4a@adacore.com> In-Reply-To: <20240216-py-simple-exc-v1-0-c275bcfb5e4a@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I noticed that one particular FinishBreakpoint test is only passing by accident -- the regexp is too broad and matches an error message. This patch changes the test to actually check what it claims to check; and then kfails the test because it doesn't work. I've taken this approach because this failure is only incidental to this series. Meanwhile I've filed a bug that I will leave open after this lands. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31391 --- gdb/testsuite/gdb.python/py-finish-breakpoint.exp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp index 45e2630337f..6b72ddb2186 100644 --- a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp @@ -73,7 +73,11 @@ with_test_prefix "normal conditions" { "check MyFinishBreakpoint hit" gdb_test "python print (finishbp.return_value)" "-5.*" "check return_value" - gdb_test "python print (finishbp_default.hit_count)" "1.*" "check finishBP on default frame has been hit" + # This test does not work and the result being checked for here + # used to match by accident. See PR python/31391. + setup_kfail "python/31391" *-*-* + gdb_test "python print ('HC=' + str(finishbp_default.hit_count))" "HC=1" \ + "check finishBP on default frame has been hit" gdb_test "python print (finishbp.is_valid())" "False.*"\ "ensure that finish bp is invalid afer normal hit" -- 2.43.0