From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 5E45D3860001 for ; Sun, 18 Feb 2024 01:10:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E45D3860001 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E45D3860001 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708218616; cv=none; b=Qz2Lx3DW2d73zp7oQZnm5yyGfS5tMsnft1pgkLHlQ/7LbiKJF7IA5CBGaJrhg7U6518yZZxJ9W5WCCECXtPmbtjN+koH9PWXsKRBqgB6zX91H32FQSrqgHI+KxpBDadtrJyPUe/DzcepsENzejdwKtktwt/hqHLNM4DJHFVXWsw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708218616; c=relaxed/simple; bh=zPukWj8LRFiJofWPQwbTPWj9hwqH6CHxQ2piALDJoXg=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=p8qqtDuVSNRsYamr4TIm8jqLrQM9uUQdyHxEUyJP4+IfkEJ7lYtyvm8UBelkVzcODfEaoGnSB0TomyEgeIxCwfNHQvlzj1igXH2I39o2PG3d+AtK8VW0zueDFvy2MFqxpTkDAPSM4Zh++FJKcEp1gS71NT5KlBTp1pda+2DSraQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id bMcarmWKSCF6GbVgzrOG1v; Sun, 18 Feb 2024 01:10:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id bVgyryVeobssWbVgyrpfMR; Sun, 18 Feb 2024 01:10:04 +0000 X-Authority-Analysis: v=2.4 cv=IaAkWnqa c=1 sm=1 tr=0 ts=65d158ec a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=43yMY_HhHjItmh1-C9QA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=a19cNqhkQYh6BDgDiM9uF7BkqhvuVq5BpBBNl63qts4=; b=EGN0c840T+dh0eZdAv3ud2DwSl H8odihiU3WqGK2whKa4gxlrmDZOyeIt9idr3H3AoppWm/D94WLTgJILLWBQ6XOeKzSDjuhMz/263/ SCCqlwLgLIJpwdyAVgc89GKsZ; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:49770 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rbVgy-003IPy-0u for gdb-patches@sourceware.org; Sat, 17 Feb 2024 18:10:04 -0700 From: Tom Tromey Date: Sat, 17 Feb 2024 18:10:02 -0700 Subject: [PATCH 1/7] Compare section index in lookup_minimal_symbol_by_pc_section MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240217-dwarf-race-relocate-v1-1-d3d2d908c1e8@tromey.com> References: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com> In-Reply-To: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rbVgy-003IPy-0u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net ([192.168.0.21]) [71.211.170.195]:49770 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFNdJCHv/Xw9ryREtcW854VoX/APfWCAxUSMtvUcZgKUgqquayTTjlwivVK4lrA+VH/EuYhDaFBqjLDxlJA+313rn71d29JC4+UdkX4oR1byHAoBgBHH l/zllz3kP8Mb0ENWkE2fMa1HklUpG4fNzCUHOpf3TzOdMXDmpoablBlMzELcubYqtMAv28KF2nWBtRO4O3cdHLIItQbKQXku77s= X-Spam-Status: No, score=-3022.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This changes lookup_minimal_symbol_by_pc_section to compare the section index when comparing two symbols. This is ok because the symbols in question always come from the same objfile. The motivation for this is to simplify a refactoring in a subsequent patch; but it is also more efficient. --- gdb/minsyms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 1b85424586f..ffded3781c4 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -901,8 +901,8 @@ lookup_minimal_symbol_by_pc_section (CORE_ADDR pc_in, struct obj_section *sectio && (msymbol[hi].size () == msymbol[hi - 1].size ()) && (msymbol[hi].unrelocated_address () == msymbol[hi - 1].unrelocated_address ()) - && (msymbol[hi].obj_section (objfile) - == msymbol[hi - 1].obj_section (objfile))) + && (msymbol[hi].section_index () + == msymbol[hi - 1].section_index ())) { hi--; continue; -- 2.43.0