From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/8] [gdb/dap] Flush after printing in log_stack
Date: Mon, 19 Feb 2024 09:23:36 +0100 [thread overview]
Message-ID: <20240219082341.21313-3-tdevries@suse.de> (raw)
In-Reply-To: <20240219082341.21313-1-tdevries@suse.de>
I noticed that function log flushes the dap log file after printing, but
that function log_stack doesn't.
Fix this by also flushing the dap log file in log_stack.
Tested on aarch64-linux.
---
gdb/python/lib/gdb/dap/startup.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/python/lib/gdb/dap/startup.py b/gdb/python/lib/gdb/dap/startup.py
index e68c5ba344e..edffc00902b 100644
--- a/gdb/python/lib/gdb/dap/startup.py
+++ b/gdb/python/lib/gdb/dap/startup.py
@@ -185,6 +185,7 @@ def log_stack(level=LogLevel.DEFAULT):
"""Log a stack trace to the log file, if logging is enabled."""
if dap_log.log_file is not None and level <= _log_level.value:
traceback.print_exc(file=dap_log.log_file)
+ dap_log.log_file.flush()
@in_gdb_thread
--
2.35.3
next prev parent reply other threads:[~2024-02-19 8:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 8:23 [PATCH 1/8] [gdb/testsuite] Set up dap log file in gdb.dap/type_checker.exp Tom de Vries
2024-02-19 8:23 ` [PATCH 2/8] [gdb/dap] Factor out thread_log Tom de Vries
2024-02-20 15:30 ` Tom Tromey
2024-02-21 13:30 ` Tom de Vries
2024-02-19 8:23 ` Tom de Vries [this message]
2024-02-20 15:30 ` [PATCH 3/8] [gdb/dap] Flush after printing in log_stack Tom Tromey
2024-02-19 8:23 ` [PATCH 4/8] [gdb/dap] Make dap log printing thread-safe Tom de Vries
2024-02-20 15:32 ` Tom Tromey
2024-02-21 13:31 ` Tom de Vries
2024-02-19 8:23 ` [PATCH 5/8] [gdb/dap] Fix race between dap startup and dap log file Tom de Vries
2024-02-20 15:38 ` Tom Tromey
2024-02-19 8:23 ` [PATCH 6/8] [gdb/dap] Don't let dap log string grow indefinitely Tom de Vries
2024-02-20 15:41 ` Tom Tromey
2024-02-21 13:34 ` Tom de Vries
2024-02-19 8:23 ` [PATCH 7/8] [gdb/dap] Join JSON reader and writer threads with DAP thread Tom de Vries
2024-02-20 15:47 ` Tom Tromey
2024-02-20 20:01 ` Tom Tromey
2024-02-21 13:35 ` Tom de Vries
2024-02-19 8:23 ` [PATCH 8/8] [gdb/dap] Fix race between dap exit and gdb exit Tom de Vries
2024-02-20 15:51 ` Tom Tromey
2024-02-21 13:39 ` Tom de Vries
2024-02-20 15:29 ` [PATCH 1/8] [gdb/testsuite] Set up dap log file in gdb.dap/type_checker.exp Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219082341.21313-3-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).