From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 8D7993858C29 for ; Mon, 19 Feb 2024 18:13:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D7993858C29 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D7993858C29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708366439; cv=none; b=JKPbBMk0z7U0KfMJOP1xTFPO6vfNhNNPhy+PjCmia7Tq7/ivVy+ov9K8fAUkk/EYvqrB+yZYJj9yphuA9xQNlC9MYxz6DmWpDXMIsrg3lHUfPhKdliiiUviCqIccyJ8u76xFTkC3oh14tClaKfOdOLvhijhbLcpkw/iGOiMx5o0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708366439; c=relaxed/simple; bh=UbhEpSGekdAWNDFtBt3R5Z6dTCcIT4Ofn2T+MIAA//Q=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=D45xKAb+tT0z6hSjpeEb+cUsVssYjUQ3KLHT+JmMaj+0YjNxZOyIoDJBCf1qlLPCcthn6A/B4wq2olGuoiaF67T5vUeZjxSY3SJ3psZd1ElOMhu0vL5XzBeSDUSIvk8oduq4bZ2DrXO4uRC8VZHX5U9gIQ5n1F9HFtLiWisrxHw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 19B4C842CB; Mon, 19 Feb 2024 18:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1708366434; bh=UbhEpSGekdAWNDFtBt3R5Z6dTCcIT4Ofn2T+MIAA//Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iG4qARgO9appGgZEBWMGWhJ3R6Ny8iYr36NSryAiovyJ8h14HptAhG9x7DIz3R6iU zmWttG7K1OGoylASNjt64BaVh/947VmZue7Z+RmS+l3FTGCg2hZzReMvtV14twqmfy tFFAWTDF1Ktmg8OLZWEysy/5DVMjfVCagyVcy3yjE5h16Obd3HDtPloAv+4xYAfCY/ 78v4DDIEwUamkslRUf3VKGDkisTwuAayrJs9p+tj4meHrkkYLrO7cLH8lgN5HIb1Cl epfGvswcovdWb/g9zvWLmBs71SfML2P+8zEgETW8GSf4FGWmq4GdrPdNiXbRtg1e8V YWso5fINXJM5g== Date: Mon, 19 Feb 2024 18:13:49 +0000 From: Lancelot SIX To: Felix Willgerodt Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/1] gdb: Document C++17 build requirement. Message-ID: <20240219181349.2olvcmvt7mwyldmt@octopus> References: <20240219145655.1833203-1-felix.willgerodt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240219145655.1833203-1-felix.willgerodt@intel.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Mon, 19 Feb 2024 18:13:54 +0000 (UTC) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Felix, Thank for catching this, I missed that part of the documentation when doing the C++17 migration. I have updated the wiki to reflect the C++17 requirement. Reviewed-By: Lancelot Six Best, Lancelot. On Mon, Feb 19, 2024 at 03:56:55PM +0100, Felix Willgerodt wrote: > We require C++17 to build for a while now: > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f74dc26792a0679e29db45e56367331ff48666d1 > > I also found another place we probably should update: > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#C.2B-.2B-_dialect > But I don't know how to do that. > > --- > gdb/doc/gdb.texinfo | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e4b89cfccfc..79805486dd6 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -40555,9 +40555,9 @@ Other packages will be used only if they are found. > > @heading Tools/Packages Necessary for Building @value{GDBN} > @table @asis > -@item C@t{++}11 compiler > -@value{GDBN} is written in C@t{++}11. It should be buildable with any > -recent C@t{++}11 compiler, e.g.@: GCC. > +@item C@t{++}17 compiler > +@value{GDBN} is written in C@t{++}17. It should be buildable with any > +recent C@t{++}17 compiler, e.g.@: GCC. > > @item GNU make > @value{GDBN}'s build system relies on features only found in the GNU > -- > 2.34.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >