From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E63623858C50 for ; Wed, 21 Feb 2024 17:09:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E63623858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E63623858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708535380; cv=none; b=ohtMGznTJxq+b8+3Vdr6O2mVwsHC3PUl2Pzfb2FzwpXN1bdQ/ndKhUFjwFXvDXbQPQBuZWJky34rn3ELktePU/5TvmeU5bifbcVdZJ6P+kq8IerjhD4ITO4/S+2Po+r7Hwg2A8dBoBMgkCJtAGcSk3Sk1lRnqEXrsPUPfNURHjc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708535380; c=relaxed/simple; bh=Zotsdq8Ixuh4nCZwKZs/jHzwtOTEgJqNHye9UKWLS4o=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rq80GR9NDQXgvBdJT4SrUP27/xVQQAmsJNDBb5J9YxQU8hP5QgirO8OoTdVSLitGbfVYe4b2hyo7BbzqAy/oeWWl4A6GQkSTeQo0cqsZxC0Xja1WZ5cBEie0M/VPKav0DFFZUSqd07tzR/DvyO7A5tK4JTzX2LNZ41kPubVIGWA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708535378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d/9Z5dfIbNsP2yq9hdxMg6qemfj4I/p1T5gDsB0Lx7s=; b=IFBt2ikMcisf+quGbQM6RjicYYjNbYI9ViAbm+bNs5ZytiOkt3PyLSagU9cFx/EPqwbmyH 6xcEWqEV9qlwI70M/DhVd1Igc5p8TlnhxtBGaDjNUNw4UPlIYaCwucd5/7UwefLxHnQ8qo Iz0b8NHRuBC2jEN/wNjnUg5GqxeOhvQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-0QOtYbFINJWOedy7zgKwcA-1; Wed, 21 Feb 2024 12:09:30 -0500 X-MC-Unique: 0QOtYbFINJWOedy7zgKwcA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71C4084AC60; Wed, 21 Feb 2024 17:09:30 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 106372166B32; Wed, 21 Feb 2024 17:09:29 +0000 (UTC) Date: Wed, 21 Feb 2024 10:09:28 -0700 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] gdb: remove some GCC version checks Message-ID: <20240221100928.62ad46c4@f39-zbm-amd> In-Reply-To: <20240221164709.54212-1-simon.marchi@efficios.com> References: <20240221164709.54212-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 21 Feb 2024 11:46:51 -0500 Simon Marchi wrote: > New in v2: > > - remove changes to nat/x86-gcc-cpuid.h > - adjust indentation in tracepoint.h > > Since we now require C++17, and therefore gcc >= 9, it's no longer > useful to have gcc version checks for older gcc version. Both patches LGTM. Reviewed-by: Kevin Buettner