From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 903E83858413 for ; Thu, 22 Feb 2024 16:18:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 903E83858413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 903E83858413 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708618690; cv=none; b=CZfu2LwloN0vuoakaj4NNR9vUAoM27g1ubdkX8Wc3iJTchWzL3Z9fzLfIU/bPz7zGzIgbZAkqB7KrKZvxSSIqcLt4iboo7Id0e8xfoH0ueoiEI0Ie2gCn4bnyFGyQFceST+4cvNoUamNLMjZwzP3urFJrwj1dRDILsXMwX9Y22U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708618690; c=relaxed/simple; bh=pVPW2hm/zTouYl0rdVSsYJI33gobA9nd5lWI+t6T1ag=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=Kfm+W0Xv8sPq2Qtb8oKgkqTopc4zXrYOoeFl0mui1SZjoqHzImOVsVr9i/dCl77cPKgmK3iL4l44m2bxVFdp/h+tufoM8c3RvofvgQfd6PkzhLCxoL/7eaA2D0/jVSw2u7HXcnAN6xb3Hu87V66kn5x4D2LxYiws2ux84EVz+ZI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6FB5A1F7B5; Thu, 22 Feb 2024 16:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708618686; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uJJcZquefzvJGc0jUIBHwELrUkscfSvyX1U9XgJzu2Q=; b=R3ec3MALTron8s9fKFFFw6i1BfWPW7thfuVJtPQ66VVnAYFsbhGDdTpEh+72y4HETjfi/y kXESToM9dZe9+ETxQf9xQQgFNBbYbrwuHHWZcRZqVHNSD9hkxahQhKWlOSe607DSWvxKIJ wovMoETxePhCBxZQllTMYk2NRhtjKd0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708618686; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uJJcZquefzvJGc0jUIBHwELrUkscfSvyX1U9XgJzu2Q=; b=Uzq95gVBeeRs+UlI5wRiCPHGCRWWXEvjzZZ5leOpPSVGwYE2iM/gkiLU+ukhSrtnAJjnLp B0JrLD5JHfdkzUCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708618686; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uJJcZquefzvJGc0jUIBHwELrUkscfSvyX1U9XgJzu2Q=; b=R3ec3MALTron8s9fKFFFw6i1BfWPW7thfuVJtPQ66VVnAYFsbhGDdTpEh+72y4HETjfi/y kXESToM9dZe9+ETxQf9xQQgFNBbYbrwuHHWZcRZqVHNSD9hkxahQhKWlOSe607DSWvxKIJ wovMoETxePhCBxZQllTMYk2NRhtjKd0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708618686; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uJJcZquefzvJGc0jUIBHwELrUkscfSvyX1U9XgJzu2Q=; b=Uzq95gVBeeRs+UlI5wRiCPHGCRWWXEvjzZZ5leOpPSVGwYE2iM/gkiLU+ukhSrtnAJjnLp B0JrLD5JHfdkzUCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 55AB9133DC; Thu, 22 Feb 2024 16:18:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id twS8E75z12W5YwAAD6G6ig (envelope-from ); Thu, 22 Feb 2024 16:18:06 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] [gdb/build] Fix static cast of virtual base Date: Thu, 22 Feb 2024 17:18:04 +0100 Message-Id: <20240222161804.1134-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=R3ec3MAL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Uzq95gVB X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.47 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MID_CONTAINS_FROM(1.00)[]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.96)[99.84%] X-Spam-Score: -3.47 X-Rspamd-Queue-Id: 6FB5A1F7B5 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: With this change in bfd/development.sh: ... -development=true +development=false ... we run into: ... In file included from tui-data.h:28:0, from tui-command.c:24: gdb-checked-static-cast.h: In instantiation of \ ‘T gdb::checked_static_cast(V*) [with T = tui_cmd_window*; V = tui_win_info]’: tui-command.c:65:15: required from here gdb-checked-static-cast.h:63:14: error: cannot convert from pointer to base \ class ‘tui_win_info’ to pointer to derived class ‘tui_cmd_window’ because \ the base is virtual T result = static_cast (v); ^~~~~~~~~~~~~~~~~~ ... Fix this by using dynamic_cast instead of gdb::checked_static_cast in TUI_CMD_WIN and TUI_STATUS_WIN. Tested on x86_64-linux, with development set to false. Reported-By: Robert Xiao Reported-By: Simon Marchi PR build/31399 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31399 --- gdb/tui/tui-data.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index 1714f5ae455..90ab01f79af 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -296,9 +296,9 @@ extern struct tui_win_info *tui_win_list[MAX_MAJOR_WINDOWS]; #define TUI_DATA_WIN \ (gdb::checked_static_cast (tui_win_list[DATA_WIN])) #define TUI_CMD_WIN \ - (gdb::checked_static_cast (tui_win_list[CMD_WIN])) + (dynamic_cast (tui_win_list[CMD_WIN])) #define TUI_STATUS_WIN \ - (gdb::checked_static_cast (tui_win_list[STATUS_WIN])) + (dynamic_cast (tui_win_list[STATUS_WIN])) /* All the windows that are currently instantiated, in layout order. */ base-commit: 94aadbf48f608a2d65d4a0ba259f43dada16fda4 -- 2.35.3