Re: Re: [PATCH v2] Add support for symbol addition to the Python API

[Matheus Branco Borella <dark.ryu.550@gmail.com>]

Tom Tromey <tom@tromey.com> writes:
> I guess because nothing makes any blocks.  However this seems like a
> kind of big issue to me, because it means that by-name lookups will
> appear to succeed ("function xyz is at address 0xaaaaa") but then
> stopping in that function won't show the name.

The big issue with properly supporting the PC-based lookups, and minsyms
in general, is that we don't actually have a properly set up BFD struct.
And, as far as I know, there's no way to actually create one without go-
ing through the trouble of generating an actual binary file in memory
and having the library read back from it.

So I did the best I could that wouldn't also have to involve potentially
fairly invasive changes to the rest of GDB.

Of course, I could be wrong and there might be a way to properly do what
I'm trying to do, but if there is one, I couldn't find it.

> gdb exposes a gdb.Architecture, maybe we could let the Python code
> specify this.

Yeah, that makes sense. I'll change it so that it uses gdb.Architecture.

> objfile_to_objfile_object returns a new reference so I think the incref
> is wrong here.
> 
> We try to avoid explicit inc/dec-refs in gdb anyway.

Yes, I didn't realize the gdbpy_ref increased the refcount
automatically.

I don't have anything to add for the other points, so suffice to say
I'll fix everything you pointed out and submit a v3 as soon as I can.

Thanks for your time.