From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH] [gdb/testsuite] Remove KFAIL for PR ada/30908
Date: Tue, 27 Feb 2024 12:23:04 +0100 [thread overview]
Message-ID: <20240227112304.13299-1-tdevries@suse.de> (raw)
PR ada/30908 turns out to be a duplicate of PR ada/12607, which was fixed by
commit d56fdf1b976 ("Refine Ada overload matching").
Remove the KFAILs for PR ada/30908.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.ada/str_binop_equal.exp | 20 ++--------------
gdb/testsuite/gdb.ada/widewide.exp | 28 ++---------------------
2 files changed, 4 insertions(+), 44 deletions(-)
diff --git a/gdb/testsuite/gdb.ada/str_binop_equal.exp b/gdb/testsuite/gdb.ada/str_binop_equal.exp
index 470fda0f129..943e0a6c414 100644
--- a/gdb/testsuite/gdb.ada/str_binop_equal.exp
+++ b/gdb/testsuite/gdb.ada/str_binop_equal.exp
@@ -31,24 +31,8 @@ runto "foo_p211_061.adb:$bp_location"
gdb_test "print my_str = my_str" \
" = true"
-set kfail_re \
- [multi_line \
- [string_to_regexp {Symbol: ada.strings.maps."="}] \
- ".*" \
- "\\$$decimal = false"]
-
-gdb_test_no_output "set debug expr 1"
-
-gdb_test_multiple {print my_str = "ABCD"} "" {
- -re -wrap " = true" {
- pass $gdb_test_name
- }
- -re -wrap $kfail_re {
- kfail ada/30908 $gdb_test_name
- }
-}
-
-gdb_test "set debug expr 0"
+gdb_test "print my_str = \"ABCD\"" \
+ " = true"
gdb_test "print my_str = \"EFGH\"" \
" = false"
diff --git a/gdb/testsuite/gdb.ada/widewide.exp b/gdb/testsuite/gdb.ada/widewide.exp
index 241f0a019c2..f1ce084667f 100644
--- a/gdb/testsuite/gdb.ada/widewide.exp
+++ b/gdb/testsuite/gdb.ada/widewide.exp
@@ -42,33 +42,9 @@ gdb_test "print my_wws(1)" "= 32 ' '"
gdb_test "print my_wws(2)" "= 104 'h'"
-set kfail_re \
- [multi_line \
- [string_to_regexp {Symbol: ada.strings.maps."="}] \
- ".*" \
- "\\$$decimal = false"]
-
-gdb_test_no_output "set debug expr 1"
-
-gdb_test_multiple {print my_wws = " helo"} "" {
- -re -wrap " = true" {
- pass $gdb_test_name
- }
- -re -wrap $kfail_re {
- kfail ada/30908 $gdb_test_name
- }
-}
-gdb_test_multiple {print my_ws = "wide"} "" {
- -re -wrap " = true" {
- pass $gdb_test_name
- }
- -re -wrap $kfail_re {
- kfail ada/30908 $gdb_test_name
- }
-}
-
-gdb_test "set debug expr 0"
+gdb_test "print my_wws = \" helo\"" " = true"
+gdb_test "print my_ws = \"wide\"" " = true"
gdb_test "print my_ws = \"nope\"" " = false"
gdb_test "print \"x\" & my_ws & \"y\"" " = \"xwidey\""
base-commit: 54af729da143016b234750b88853209c142ae5e7
--
2.35.3
next reply other threads:[~2024-02-27 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 11:23 Tom de Vries [this message]
2024-02-27 14:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227112304.13299-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).