From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 0/3] Use ui-out tables in a few spots
Date: Sun, 03 Mar 2024 11:43:02 -0700 [thread overview]
Message-ID: <20240303-info-proc-ui-out-v2-0-cf3d2013b33e@tromey.com> (raw)
This series changes a few spots to use ui-out tables rather than
hand-aligned printf-based ones. I think ui-out tables should
generally be preferred:
* They are more flexible and easier to use
* They sometimes provide automatic styling (like addresses in this
series)
* They allow the possibility of structured reuse via MI
There are still a few such tables left in gdb after this series, but
they are all in code I can't readily test: fbsd-tdep.c,
darwin-nat-info.c, and netbsd-tdep.c.
Regression tested on x86-64 Fedora 38.
---
Changes in v2:
- Rebased
- Fixed test failure pointed out in review
- Link to v1: https://inbox.sourceware.org/gdb-patches/20230809-info-proc-ui-out-v1-0-36d4b1b8f582@tromey.com
---
Tom Tromey (3):
Use ui-out in maintenance_print_user_registers
Use ui-out in core_target::info_proc_mappings
Use ui-out tables in linux-tdep.c
gdb/corelow.c | 54 +++++++---------
gdb/linux-tdep.c | 114 ++++++++++++++--------------------
gdb/testsuite/gdb.base/completion.exp | 2 +-
gdb/user-regs.c | 14 ++++-
4 files changed, 81 insertions(+), 103 deletions(-)
---
base-commit: 90f8d97c8efa75f7f019b868eca9c626bc35203d
change-id: 20230809-info-proc-ui-out-ce83b44285ec
Best regards,
--
Tom Tromey <tom@tromey.com>
next reply other threads:[~2024-03-03 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 18:43 Tom Tromey [this message]
2024-03-03 18:43 ` [PATCH v2 1/3] Use ui-out in maintenance_print_user_registers Tom Tromey
2024-03-03 18:43 ` [PATCH v2 2/3] Use ui-out in core_target::info_proc_mappings Tom Tromey
2024-03-03 18:43 ` [PATCH v2 3/3] Use ui-out tables in linux-tdep.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240303-info-proc-ui-out-v2-0-cf3d2013b33e@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).