From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EADCA3858C3A for ; Wed, 6 Mar 2024 12:51:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EADCA3858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EADCA3858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709729501; cv=none; b=khA1tMQjZxS4Kxi0z1+5/mb6Za//DEatTU6jUG0pwZ1xA3HbPxkcbyE0Ffxrob3muM03eIHvBMa2J61QWjXlY9vbj6/dcngwQHk9RwZFrDNSVyFv1y8i97iT3z7p7G/QgyX9Prgy8ntDrhii9G3MXL+ehwAatp0uSCBYWajKhd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709729501; c=relaxed/simple; bh=obG9A5GFjq1zv1R+XJmNDKEJrugPKpMmjEErUSH8028=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kpBWeVNMQTp8D6qvq+/3CLAe4t0hIzcV0MZqXIAxmQDeuHWmMnNsz5dZsJ6gyuDXiDVYDkYrMCCu2pDhjUDhXj62QSHTOtCxg9a3GJnKkEOh4Wu/9xa8CK7+Q3nlZAtMu0vMZxX+oYWALW45Fm1aZdXfp6Ra/w1njwn3SGdx5NI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709729499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k6h5hXoCZuESca0zKafmpo8Ad/AMPNfXSMQTkQ1IqTo=; b=Z/VhPAVghZ5v1ThC7zcK/u4KrVXVrJ5eEDzdQGCfp8Hviop36sFN1WPPDbipWLMIi5vLuZ VX7BBLW0o3W/S9ZayDIq9uP/9PNkzammfqAHlH9bL/fx+swQzffUom+fhaqe4x3QDKaUcE HUmpmu1VVa+Tg4BcM28HOzln2TN5uuM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-dGrXz65pNsiqMPoHGYrzQw-1; Wed, 06 Mar 2024 07:51:38 -0500 X-MC-Unique: dGrXz65pNsiqMPoHGYrzQw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0F8EA800269 for ; Wed, 6 Mar 2024 12:51:38 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.226.190]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B98F2022AA9; Wed, 6 Mar 2024 12:51:37 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: [PATCH 0/4] Modernize frame unwinders and add disable feature Date: Wed, 6 Mar 2024 13:51:31 +0100 Message-ID: <20240306125135.766567-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch series started with me trying to make it easier to test GDB's ability to unwind using CFI data, to improve a previous patch I sent to the list. However, once I finished these changes, I realized there was an unrelated bug I should fix before proposing the CFI test. Since these changes are significant enough already, and I think would be interesting on their own, I figured I shoudl submit this patch series as is right now while I figure out the other bug. The first patch is just a minor change, storing frame unwinders in a vector instead of through an unwinder table accessible using the registry system. This isn't required (like I originally thought it was), but it does make the whole system more readable in my opinion. Patch 3 has the real meat of the modernization, making GDB use polymorphism to handle frame unwinders. This is slightly slower than using function pointers, but much more readable in my opinion. As for the unwinder classes, they were chosen somewhat arbitrarily, mostly based on where I found an unwinder and its name. I almost expect some unwinders to be mis-categorized, but that should be easy to fix. The changes up to patch 3 have been tested with a try-branch, no regressions as far as I could see. Guinevere Larsen (4): gdb: make gdbarch store a vector of frame unwinders gdb: add "unwinder class" to frame unwinders gdb: Migrate frame unwinders to use C++ classes GDB: introduce ability to disable frame unwinders gdb/NEWS | 7 + gdb/aarch64-tdep.c | 12 +- gdb/alpha-mdebug-tdep.c | 6 +- gdb/alpha-tdep.c | 12 +- gdb/amd64-obsd-tdep.c | 6 +- gdb/amd64-tdep.c | 24 +- gdb/amd64-windows-tdep.c | 6 +- gdb/amdgpu-tdep.c | 5 +- gdb/arc-tdep.c | 10 +- gdb/arch-utils.c | 8 + gdb/arm-tdep.c | 29 +- gdb/avr-tdep.c | 5 +- gdb/bfin-tdep.c | 6 +- gdb/bpf-tdep.c | 6 +- gdb/cris-tdep.c | 12 +- gdb/csky-tdep.c | 10 +- gdb/doc/gdb.texinfo | 24 ++ gdb/dummy-frame.c | 8 +- gdb/dummy-frame.h | 2 +- gdb/dwarf2/frame-tailcall.c | 6 +- gdb/dwarf2/frame-tailcall.h | 2 +- gdb/dwarf2/frame.c | 16 +- gdb/frame-unwind.c | 359 ++++++++++++++---- gdb/frame-unwind.h | 165 +++++++- gdb/frame.c | 28 +- gdb/frv-linux-tdep.c | 6 +- gdb/frv-tdep.c | 5 +- gdb/ft32-tdep.c | 6 +- gdb/gdbarch.c | 3 + gdb/gdbarch.h | 5 + gdb/gdbarch.py | 3 + gdb/h8300-tdep.c | 5 +- gdb/hppa-linux-tdep.c | 5 +- gdb/hppa-tdep.c | 17 +- gdb/i386-obsd-tdep.c | 5 +- gdb/i386-tdep.c | 30 +- gdb/ia64-tdep.c | 24 +- gdb/inline-frame.c | 5 +- gdb/inline-frame.h | 2 +- gdb/iq2000-tdep.c | 5 +- gdb/jit.c | 6 +- gdb/lm32-tdep.c | 5 +- gdb/loongarch-tdep.c | 7 +- gdb/m32c-tdep.c | 5 +- gdb/m32r-linux-tdep.c | 5 +- gdb/m32r-tdep.c | 5 +- gdb/m68hc11-tdep.c | 5 +- gdb/m68k-linux-tdep.c | 6 +- gdb/m68k-tdep.c | 6 +- gdb/mep-tdep.c | 5 +- gdb/microblaze-tdep.c | 6 +- gdb/mips-sde-tdep.c | 6 +- gdb/mips-tdep.c | 24 +- gdb/mn10300-tdep.c | 5 +- gdb/moxie-tdep.c | 5 +- gdb/msp430-tdep.c | 5 +- gdb/nds32-tdep.c | 14 +- gdb/nios2-tdep.c | 12 +- gdb/or1k-tdep.c | 7 +- gdb/ppc-fbsd-tdep.c | 5 +- gdb/ppc-obsd-tdep.c | 5 +- gdb/python/py-unwind.c | 50 ++- gdb/record-btrace.c | 12 +- gdb/record.h | 4 +- gdb/riscv-tdep.c | 8 +- gdb/rl78-tdep.c | 6 +- gdb/rs6000-aix-tdep.c | 5 +- gdb/rs6000-tdep.c | 12 +- gdb/rx-tdep.c | 10 +- gdb/s12z-tdep.c | 7 +- gdb/s390-linux-tdep.c | 5 +- gdb/s390-tdep.c | 10 +- gdb/sentinel-frame.c | 8 +- gdb/sentinel-frame.h | 2 +- gdb/sh-tdep.c | 11 +- gdb/sparc-netbsd-tdep.c | 6 +- gdb/sparc-obsd-tdep.c | 6 +- gdb/sparc-sol2-tdep.c | 6 +- gdb/sparc-tdep.c | 6 +- gdb/sparc64-fbsd-tdep.c | 6 +- gdb/sparc64-netbsd-tdep.c | 6 +- gdb/sparc64-obsd-tdep.c | 12 +- gdb/sparc64-sol2-tdep.c | 6 +- gdb/sparc64-tdep.c | 6 +- gdb/testsuite/gdb.base/frame-unwind-disable.c | 21 + .../gdb.base/frame-unwind-disable.exp | 114 ++++++ gdb/tic6x-tdep.c | 12 +- gdb/tilegx-tdep.c | 5 +- gdb/tramp-frame.c | 50 ++- gdb/v850-tdep.c | 5 +- gdb/vax-tdep.c | 6 +- gdb/windows-tdep.c | 33 +- gdb/windows-tdep.h | 16 +- gdb/xstormy16-tdep.c | 5 +- gdb/xtensa-tdep.c | 7 +- gdb/z80-tdep.c | 7 +- 96 files changed, 1098 insertions(+), 442 deletions(-) create mode 100644 gdb/testsuite/gdb.base/frame-unwind-disable.c create mode 100644 gdb/testsuite/gdb.base/frame-unwind-disable.exp -- 2.43.2