From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by sourceware.org (Postfix) with ESMTPS id B285A3858401 for ; Thu, 11 Apr 2024 05:26:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B285A3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B285A3858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712813171; cv=none; b=FTlRdAPyXyhDZtQ20DZ/BUlqesQvvD3vn/pHfEIK4smoly0S7Nc/Db+IfYs456955XUiw8VVYTuv3VxIgXX+shsNAqyVmhyTREzWYhtlD0cfPVgQaUFdJuPaDNgfr/B8GfbAIrh+VUt+mehBm6nb3otCIav+eCL14oR/2W+JfLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712813171; c=relaxed/simple; bh=p6ASZj2P0VfVD6pdqNWT/WJqkTBfdfq2SVw8SsDARn8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=kaKzK9w6PCUw9X2XW5zAOCD/rzbp3MEDirKJSz+TaigEhctG0yS47eMsbjgvuO9tC9kLNB7MqEhDTmkrfJbgm3mUkXFCXoyUvM2STNF7q6839W1mmpQ0dUnlEaUi2Hx1AEfjCAzlpLpWFezQ6oY1mvomLynzauxOcTsR3+yp9B8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712813168; x=1744349168; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=p6ASZj2P0VfVD6pdqNWT/WJqkTBfdfq2SVw8SsDARn8=; b=g+gIzzF9TiylnULqulLXDNX11yQHISX9mfM9kYRsN9nEUUeIKB8cXBoT 1HmwK/1D/luTPClVo9JYeq7esaoVVgj2bYgp4apRu0QYlXuVOT5KIiW2v lca3aexSCK6aHxrKCBK09nRV6m+xLNu+41IpaEo8R53MrWQ7r30z9aMFA 7YzhkxygHrirU3YTQXbR2+l1OVopGqBDfaZ0X67TrZA3rpJKZjOGkurNC tSSJyj+VCVx0JjKWKIETlVg82wHAa07jE3ofDf7P1Uplq5UNn6ar0au7R vdVrfrozH2tzkzngRoqUWa/IcShgOZlFwzjXUZQ6+L/3/AhLZ3EHLS7Y2 Q==; X-CSE-ConnectionGUID: R4Df6mDBTHKPPdDM/32upQ== X-CSE-MsgGUID: uI5fZ77VTEaU6uQtsnlK/Q== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="8367985" X-IronPort-AV: E=Sophos;i="6.07,192,1708416000"; d="scan'208";a="8367985" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 22:26:07 -0700 X-CSE-ConnectionGUID: 0RlkUqaITzec/fV0TS5LRA== X-CSE-MsgGUID: 8DFhhL+ISkuIc/2tbs6+yA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,192,1708416000"; d="scan'208";a="20764408" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 22:26:06 -0700 From: Markus Metzger To: gdb-patches@sourceware.org Cc: pedro@palves.net Subject: [PATCH v2 0/6] fix PR gdb/19340 Date: Thu, 11 Apr 2024 05:25:58 +0000 Message-Id: <20240411052604.87893-1-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Fix PR gdb/19340 by stopping replaying the current thread before disabling recording. While writing the test for this, I wondered whether it would also work if there was more than one process and if some were recording while others were replaying. It turned out that recording one process while some other process is replaying doesn't work. You first have to stop replaying everything before you can continue recording. Since btrace is per inferior, this seems like an unnecessary restriction. The first patch fixes gdb/pr19340; the rest makes recording work together with replaying on inferior level. The most prominent change is probably that do_target_wait() no longer silently switches inferiors. This infrun change requires global maintainer approval. Changes to v1: - fixed a fail in a newly added test - fixed fails in patch 5, which also caused the patch to get renamed Markus Metzger (6): gdb, btrace: fix pr19340 gdb, btrace: simplify gdb.btrace/multi-inferior.exp gdb, btrace: remove record_btrace_target::supports_*() gdb, btrace: set wait status to ignore if nothing is moving gdb, infrun: fix silent inferior switch in do_target_wait() gdb, btrace, infrun: per-inferior run-control gdb/infrun.c | 63 ++++++++++++++--- gdb/linux-nat.c | 17 +++-- gdb/record-btrace.c | 78 +++++++-------------- gdb/remote.c | 22 ++++-- gdb/testsuite/gdb.btrace/multi-inferior.c | 10 ++- gdb/testsuite/gdb.btrace/multi-inferior.exp | 33 ++++----- gdb/testsuite/gdb.btrace/step.exp | 22 ++++-- 7 files changed, 150 insertions(+), 95 deletions(-) -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928