From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id A5AB23858CDB for ; Wed, 17 Apr 2024 21:04:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5AB23858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A5AB23858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713387900; cv=none; b=RRgIxHYiNeLjYX1wOczzj2xRbQw7Gh9LGb3c9B7++j2eem6GNJnvacC+BF0SDoIYskPci1GY31ocXzrbbDt7hBvifQKXMqqziTzRytJltr5qJIWiXKn3OIEf2iXIlUq6xDyqRQYRyLg7MvlxxU+i5CeMYKO8t6JpA6EWoMses9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713387900; c=relaxed/simple; bh=5sDr5g7U2ywTRYm1e6GUiteL43TzBcSbyiTAO8R27Z8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Cz3PueFE16f2fIPlCXdvv4n3Dj/yYIzqyz34n8bS4MX/Mr0wfascEcx3pQrplToA2bdIZ/etzeGnkhbJRvq1jY9hv0OjithNKdHAg7JvY4GKw0n8Sqfw6dkS6N2Rl9yEdjRy1IBeQcMnaKomRHd1L1JpdlNxxtbBpiwmPi3iibg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1e0bec01232so1727725ad.3 for ; Wed, 17 Apr 2024 14:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713387893; x=1713992693; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Udz0sOQRKXAm5kiKFSTNh5JUUjk+Jni+c5SH40tgmE=; b=eHgT3ib4old2pbyv5qADfgiTguIXGbRpHsR0VbqxbycJRgZ0QcxH8e12Oep5HbH8jZ zaqY/Ra0nrj4RooobTlwh/0LAQMs0tW+tzAms/GCQxSY8y1EMdtU2HA8hKbbPbvf5lVf ne53sYy2n2FryzPSu3xGTBqUryJrDNYxVONBi6N5S9x3b1OvEScDCaQfKtzs1YefUZAr zkaZ2ECBAx7PfNmMDu8OltNAmigtu4s6xkyuzKujRFdGRajujhO2MuNSWQUJnie/BMpg VAghLLCc69lCXdWHXAURQG5pANlGy4fYOsZUEWZNDhOzbkfpK/twVigOu+qAlI4PsyUA kY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713387893; x=1713992693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Udz0sOQRKXAm5kiKFSTNh5JUUjk+Jni+c5SH40tgmE=; b=vTHxKFZVnSIKT0I+jqEGpcBWlCVzFcvHb0DukK4zFWbMqZvRinOhDfPZbdX2pytu9u hKUXQ3v/2qjXotmte/KNZpgu+CLc23IevlfFgn8r9sNCldjCZQQGedhmJbRyXWF7BaKs Rg2FQb+vbvgfKLjPjtMuoxqImWSxwdTiDTRVKS9pKFKGI0DQPi1s3hYrlOjIPKoC2WKW GKo3nWDG70s2ex4IcGtHaN8lMvjBdhYx2YwtwrZI5wRpNXxEuhQOclOit/FKkNwbUHeV Cf5t/AjFCnyYKkKK9NfSgjopK0hIY7JOsp60fWqOMEQjenKaPiMw7JU9mVeyyvqtRAi8 Gu2Q== X-Gm-Message-State: AOJu0YzeqABcUDC9nnRig9mIHneSkGHilxR1VBuyi6bpnV1BykFMylgw eyRTDY6XxSxgI54Gr+5c1DJNCHWGZ9J7BNBY0RID665J9zjeH3r6Ct38RHPcHoep+JColo1lLpG X X-Google-Smtp-Source: AGHT+IFwZqnifahhN4yZPNFgU3xM7wJ+vCSR8e/9k6XyvA6xr4j5HU4GjNP2CyblJBvXfL9SN2VE9w== X-Received: by 2002:a17:902:a70b:b0:1de:e6a5:e51d with SMTP id w11-20020a170902a70b00b001dee6a5e51dmr673737plq.16.1713387893418; Wed, 17 Apr 2024 14:04:53 -0700 (PDT) Received: from amd.. ([2804:7f0:b403:ad57:3e7c:3fff:fe7a:e83b]) by smtp.gmail.com with ESMTPSA id l9-20020a170903120900b001e3e0aa9776sm80494plh.27.2024.04.17.14.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 14:04:53 -0700 (PDT) From: Gustavo Romero To: gdb-patches@sourceware.org Cc: luis.machado@arm.com, thiago.bauermann@linaro.org, eliz@gnu.org, tom@tromey.com, gustavo.romero@linaro.org Subject: [PATCH v5 4/8] gdb: Use passed gdbarch instead of calling current_inferior Date: Wed, 17 Apr 2024 21:04:20 +0000 Message-Id: <20240417210424.216374-5-gustavo.romero@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240417210424.216374-1-gustavo.romero@linaro.org> References: <20240417210424.216374-1-gustavo.romero@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In do_examine function, use passed gdbarch when checking if an address is tagged instead of calling current_inferior()->arch() to make the code more localized and help modularity by not calling a current_* function, which disguises the use of a global state/variable. There is no change in the code behavior. Signed-off-by: Gustavo Romero Suggested-by: Thiago Jung Bauermann Approved-By: Luis Machado Tested-By: Luis Machado --- gdb/printcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 5635f605314..4edbd458e4d 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -1132,7 +1132,7 @@ do_examine (struct format_data fmt, struct gdbarch *gdbarch, CORE_ADDR addr) = value_from_ulongest (builtin_type (gdbarch)->builtin_data_ptr, tag_laddr); - if (gdbarch_tagged_address_p (current_inferior ()->arch (), v_addr)) + if (gdbarch_tagged_address_p (gdbarch, v_addr)) { /* Fetch the allocation tag. */ struct value *tag -- 2.34.1