From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 1/4] Fix some minor header file irregularities
Date: Thu, 18 Apr 2024 09:41:56 -0600 [thread overview]
Message-ID: <20240418-header-check-v2-1-725529851603@adacore.com> (raw)
In-Reply-To: <20240418-header-check-v2-0-725529851603@adacore.com>
The script in the next patch noticed some irregularities in some
headers: trailing or leading blank lines, or in one case a missing
copyright header. This patch fixes these.
---
gdb/disasm-flags.h | 1 -
gdb/gdbtypes.h | 1 -
gdb/parser-defs.h | 1 -
gdb/tracefile.h | 18 ++++++++++++++++++
gdb/windows-nat.h | 1 -
gdb/xml-tdesc.h | 1 -
6 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/gdb/disasm-flags.h b/gdb/disasm-flags.h
index 4f711259453..b2f0ec95b07 100644
--- a/gdb/disasm-flags.h
+++ b/gdb/disasm-flags.h
@@ -38,4 +38,3 @@ enum gdb_disassembly_flag : unsigned
DEF_ENUM_FLAGS_TYPE (enum gdb_disassembly_flag, gdb_disassembly_flags);
#endif /* DISASM_FLAGS_H */
-
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index f80bd7e071a..55018f2c344 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -1,4 +1,3 @@
-
/* Internal type definitions for GDB.
Copyright (C) 1992-2024 Free Software Foundation, Inc.
diff --git a/gdb/parser-defs.h b/gdb/parser-defs.h
index 5d3c1893836..9774a465ee2 100644
--- a/gdb/parser-defs.h
+++ b/gdb/parser-defs.h
@@ -390,4 +390,3 @@ extern bool fits_in_type (int n_sign, const gdb_mpz &n, int type_bits,
extern void parser_fprintf (FILE *, const char *, ...) ATTRIBUTE_PRINTF (2, 3);
#endif /* PARSER_DEFS_H */
-
diff --git a/gdb/tracefile.h b/gdb/tracefile.h
index 9c7fdea7297..90967eff855 100644
--- a/gdb/tracefile.h
+++ b/gdb/tracefile.h
@@ -1,3 +1,21 @@
+/* Tracefile declarations
+ Copyright (C) 2014-2024 Free Software Foundation, Inc.
+
+ This file is part of GDB.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
#ifndef TRACEFILE_H
#define TRACEFILE_H 1
diff --git a/gdb/windows-nat.h b/gdb/windows-nat.h
index 5422aa064e9..3fbb1ea35df 100644
--- a/gdb/windows-nat.h
+++ b/gdb/windows-nat.h
@@ -37,4 +37,3 @@ extern const int amd64_mappings[];
#endif
#endif
-
diff --git a/gdb/xml-tdesc.h b/gdb/xml-tdesc.h
index 823dbee0f2d..cd6e79cc24f 100644
--- a/gdb/xml-tdesc.h
+++ b/gdb/xml-tdesc.h
@@ -50,4 +50,3 @@ std::optional<std::string> target_fetch_description_xml (target_ops *ops);
const struct target_desc *string_read_description_xml (const char *xml);
#endif /* XML_TDESC_H */
-
--
2.43.0
next prev parent reply other threads:[~2024-04-18 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 15:41 [PATCH v2 0/4] Add include guard checker and reformatter Tom Tromey
2024-04-18 15:41 ` Tom Tromey [this message]
2024-04-18 15:41 ` [PATCH v2 2/4] Add an include-checking script Tom Tromey
2024-04-18 19:25 ` Simon Marchi
2024-04-19 14:54 ` Tom Tromey
2024-04-19 15:03 ` Tom Tromey
2024-04-18 15:41 ` [PATCH v2 3/4] Add check-include-guards.py to pre-commit Tom Tromey
2024-04-18 15:41 ` [PATCH v2 4/4] Run check-include-guards.py Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418-header-check-v2-1-725529851603@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).