From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 06/10] Remove some unnecessary allocations from cpname_state::parse_number
Date: Sun, 21 Apr 2024 11:00:06 -0600 [thread overview]
Message-ID: <20240421-canon-fixes-v1-6-4dc4791d270d@tromey.com> (raw)
In-Reply-To: <20240421-canon-fixes-v1-0-4dc4791d270d@tromey.com>
cpname_state::parse_number allocates nodes for various types and then
only uses one of them. This patch reduces the number of allocations
by not performing the unnecessary ones.
---
gdb/cp-name-parser.y | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y
index 6590194545f..692fe84071c 100644
--- a/gdb/cp-name-parser.y
+++ b/gdb/cp-name-parser.y
@@ -1290,8 +1290,6 @@ cpname_state::parse_number (const char *p, int len, int parsed_float,
/* Number of "L" suffixes encountered. */
int long_p = 0;
- struct demangle_component *signed_type;
- struct demangle_component *unsigned_type;
struct demangle_component *type, *name;
enum demangle_component_type literal_type;
@@ -1362,25 +1360,26 @@ cpname_state::parse_number (const char *p, int len, int parsed_float,
if (long_p == 0)
{
- unsigned_type = make_builtin_type ("unsigned int");
- signed_type = make_builtin_type ("int");
+ if (unsigned_p)
+ type = make_builtin_type ("unsigned int");
+ else
+ type = make_builtin_type ("int");
}
else if (long_p == 1)
{
- unsigned_type = make_builtin_type ("unsigned long");
- signed_type = make_builtin_type ("long");
+ if (unsigned_p)
+ type = make_builtin_type ("unsigned long");
+ else
+ type = make_builtin_type ("long");
}
else
{
- unsigned_type = make_builtin_type ("unsigned long long");
- signed_type = make_builtin_type ("long long");
+ if (unsigned_p)
+ type = make_builtin_type ("unsigned long long");
+ else
+ type = make_builtin_type ("long long");
}
- if (unsigned_p)
- type = unsigned_type;
- else
- type = signed_type;
-
name = make_name (p, len);
lvalp->comp = fill_comp (literal_type, type, name);
--
2.44.0
next prev parent reply other threads:[~2024-04-21 17:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 17:00 [PATCH 00/10] Fix some C++ name canonicalizer problems Tom Tromey
2024-04-21 17:00 ` [PATCH 01/10] Remove test code from cp-name-parser.y Tom Tromey
2024-04-22 17:11 ` John Baldwin
2024-04-21 17:00 ` [PATCH 02/10] Allow initialization functions in .y files Tom Tromey
2024-04-21 17:00 ` [PATCH 03/10] Clean up demangle_parse_info Tom Tromey
2024-04-22 17:12 ` John Baldwin
2024-04-21 17:00 ` [PATCH 04/10] Change storage of demangle_component Tom Tromey
2024-04-22 17:17 ` John Baldwin
2024-04-21 17:00 ` [PATCH 05/10] Fix C++ name canonicalizations of character literals Tom Tromey
2024-04-22 17:19 ` John Baldwin
2024-04-21 17:00 ` Tom Tromey [this message]
2024-04-22 17:20 ` [PATCH 06/10] Remove some unnecessary allocations from cpname_state::parse_number John Baldwin
2024-04-21 17:00 ` [PATCH 07/10] Fix C++ canonicalization of hex literals Tom Tromey
2024-04-22 17:22 ` John Baldwin
2024-04-21 17:00 ` [PATCH 08/10] Implement C++14 numeric separators Tom Tromey
2024-04-22 17:29 ` John Baldwin
2024-04-24 21:42 ` Tom Tromey
2024-04-30 16:33 ` John Baldwin
2024-04-21 17:00 ` [PATCH 09/10] Allow function types as template parameters in name canonicalizer Tom Tromey
2024-04-22 17:30 ` John Baldwin
2024-04-21 17:00 ` [PATCH 10/10] Add spaceship operator to cp-name-parser.y Tom Tromey
2024-04-22 17:31 ` John Baldwin
2024-05-14 19:29 ` [PATCH 00/10] Fix some C++ name canonicalizer problems Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240421-canon-fixes-v1-6-4dc4791d270d@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).