From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3EA763858D1E for ; Sun, 21 Apr 2024 21:02:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EA763858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3EA763858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713733352; cv=none; b=nR59DG6Pb0IGop7+x0VJ8+dr+0pUd+LMnSr0J1aJVvwYbDizcdtRnBhXK3+hpavmklBAns4ZMgOeYg/3FIYawEBf3/gB6+3bqe2eD4vAHsd6qZjQUibqpfsg+nVVzR4GnurzDq0ZKQQrq2gn9iwxBD7p7zA2RG2rDa07FHL6s+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713733352; c=relaxed/simple; bh=d879XG6e1MxZR3YGRVPvhqKi2wXasSjD7hZU8UB/v5c=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=TpHvvGrXK4+Tp8l133gaKtLV1L4JIIA05rEX37mL+l+HrRs4s9k6Hsoto0ZahojAg28VyHY5YwrGq7uZpCS9IsZHOH2gmjPCWhTI/qAYKqXHa4dYHjukEo7DIYwwDY+ew3FlIcEruKZhjE3CvKVgDBAnFyLRqzNbsb1gyLdHEP4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713733348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K6Ej0JEnnkWIU1S+QQCNuxu3AFSBlFQMyL7rxJdgNvk=; b=fe/GVtJoI5VdqZy5b+C8pzk795VEjJplQsvA87tWYvEfanPjQC4Did4PXuIibhRiq76grG tigTOemQjaM3tfTqB666bmjYewbZcvUHlHuOOb5op7/E7Ky5mBomcW+gpX0HDCAImeqlwO 54bWnJXfSvq0tuB3+U50usKeRWTppu0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-rGFjNmP6OpqitcPMngQ4Pw-1; Sun, 21 Apr 2024 17:02:27 -0400 X-MC-Unique: rGFjNmP6OpqitcPMngQ4Pw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1167B29AA2C8; Sun, 21 Apr 2024 21:02:27 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF001492BC7; Sun, 21 Apr 2024 21:02:26 +0000 (UTC) Date: Sun, 21 Apr 2024 14:02:25 -0700 From: Kevin Buettner To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb/testsuite: Add libc_has_debug_info require helper Message-ID: <20240421140225.455d785f@f39-zbm-amd> In-Reply-To: <20240421134406.2c6ac5af@f39-zbm-amd> References: <20240420213307.976401-1-thiago.bauermann@linaro.org> <20240420213307.976401-2-thiago.bauermann@linaro.org> <20240421134406.2c6ac5af@f39-zbm-amd> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 21 Apr 2024 13:44:06 -0700 Kevin Buettner wrote: > On Sat, 20 Apr 2024 18:33:06 -0300 > Thiago Jung Bauermann wrote: > > > Factor the test for libc debug info out of gdb.base/relativedebug.exp to > > a new procedure. > > > > Also, change the "info sharedlibrary" test to explicitly detect when > > libc has debug info. > > LGTM. > > Approved-by: Kevin Buettner Just found a problem... While attempting to test part 2 using clang: make check RUNTESTFLAGS="CC_FOR_TARGET=clang" TESTS="gdb.base/memops-watchpoint.exp" Then, in the log file: get_compiler_info: clang-17-0-6 Executing on host: clang /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c -fdiagnostics-color=never -Wno-unknown-warning-option -w -g -g -lm -o /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.x (timeout = 300) builtin_spawn -ignore SIGHUP clang /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c -fdiagnostics-color=never -Wno-unknown-warning-option -w -g -g -lm -o /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.x /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c:3:6: error: call to undeclared library function 'printf' with type 'int (const char *, ...)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 3 | printf ("Hello, world!\n"); | ^ /mesquite2/sourceware-git/f39-review/bld/gdb/testsuite/temp/164548/libc_has_debug_info.c:3:6: note: include the header or explicitly provide a declaration for 'printf' 1 error generated. compiler exited with status 1 UNSUPPORTED: gdb.base/memops-watchpoint.exp: require failed: libc_has_debug_info (failed to compile test program) My testing shows that things will work if you add the suggested #include to the "set src" text. Kevin