From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 58AF43849AEE for ; Tue, 23 Apr 2024 17:09:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58AF43849AEE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 58AF43849AEE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713892196; cv=none; b=Zl9BhmIMexCdybGeFx8OxKpezaAKpaq9WEe/N5sb3aML6VU67u6r7NsqjPYgO5194VHMtH+Hh9aLOeHdnISp4ADXynExxMSKA0ZYaMlel0zfUCWYnuAHu0/2waEgMgZUait5fvXU2ld9oriIrnMCVuU7QKNbm326lP2rXW6WKLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713892196; c=relaxed/simple; bh=0By35odmG3DEZ3iOMeXaLUmxev/TbJ0tEtLH3UgYjbg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=D7B3YZ+Gs1s6UKVr/HYS9LS6H0a00X1yPOzapn+dAGQyJWmZED9wyYKJ6R4NgsqLHbGrDQiJg25mUYK80D3D9zrBIEI5HZUoJiBABLZ5aotl8sSLd2actIDUXEFGS7ura/kQa2g2Xf9BUIaxAFX1jHR4JREQ8yTUf+pR1s7yU9U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713892194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Gr1Wr29z6R8AvEfeZSLpKQYn+FHDUSaI4C4nF+UGzQ=; b=epmc2OGvEWPEehGCWEqSfGV1dd2WyeOY9rJwpaHNYoep//6TgKqMFmcr14fscUPAekXZ// 3xFCDjlWwkuC6K5qOeaktlRvcPPu6he7EKnGqG/nkiGpqdXln7HByR/wT2l+vYTAyae/Ah 5IPMl18t4rSZgjfKw1gspdzb0rB5niY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-mp9zIwejNN6FQtmASiahCA-1; Tue, 23 Apr 2024 13:09:50 -0400 X-MC-Unique: mp9zIwejNN6FQtmASiahCA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D71D418138AA; Tue, 23 Apr 2024 17:09:49 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 756DD2166B31; Tue, 23 Apr 2024 17:09:49 +0000 (UTC) Date: Tue, 23 Apr 2024 10:09:47 -0700 From: Kevin Buettner To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper Message-ID: <20240423100947.3d5692be@f39-zbm-amd> In-Reply-To: <20240422230700.1173173-2-thiago.bauermann@linaro.org> References: <20240422230700.1173173-1-thiago.bauermann@linaro.org> <20240422230700.1173173-2-thiago.bauermann@linaro.org> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 22 Apr 2024 20:06:59 -0300 Thiago Jung Bauermann wrote: > Factor the test for libc debug info out of gdb.base/relativedebug.exp to > a new procedure. > > Also, change the "info sharedlibrary" test to explicitly detect when > libc has debug info. > --- > > As mentioned in the cover letter, the new testcase doesn't use this helper > procedure anymore so this is an optional patch. I think it's a nice > cleanup, though I didn't find any other testcase that need it so perhaps > the new helper is not as useful as I imagine it to be. I'm fine with not > committing this patch. > > Changes in v3: > - Include in test program to avoid error when using clang > (suggested by Kevin). I agree that it's a nice cleanup and I think that it should go in. I've retested with CC_FOR_TARGET set to clang and also gcc. It works for both. Approved-by: Kevin Buettner