From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed 2/2] [gdb/testsuite] Fix gdb.threads/threadcrash.exp for remote host
Date: Wed, 24 Apr 2024 15:36:22 +0200 [thread overview]
Message-ID: <20240424133622.4639-2-tdevries@suse.de> (raw)
In-Reply-To: <20240424133622.4639-1-tdevries@suse.de>
With test-case gdb.threads/threadcrash.exp using host board local-remote-host
and target board remote-gdbserver-on-localhost I run into:
...
(gdb) PASS: gdb.threads/threadcrash.exp: test_gcore: continue to crash
gcore $outputs/gdb.threads/threadcrash/threadcrash.gcore^M
Failed to open '$outputs/gdb.threads/threadcrash/threadcrash.gcore' for output.^M
(gdb) FAIL: gdb.threads/threadcrash.exp: test_gcore: saving gcore
UNSUPPORTED: gdb.threads/threadcrash.exp: test_gcore: couldn't generate gcore file
...
The problem is that the gcore command tries to save a file on a remote host,
but the filename is a location on build.
Fix this by using host_standard_output_file.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.threads/threadcrash.exp | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp b/gdb/testsuite/gdb.threads/threadcrash.exp
index ffbfd83942c..6da70736983 100644
--- a/gdb/testsuite/gdb.threads/threadcrash.exp
+++ b/gdb/testsuite/gdb.threads/threadcrash.exp
@@ -251,17 +251,15 @@ proc_with_prefix test_gcore {} {
}
gdb_test "continue" ".*Segmentation fault.*" "continue to crash"
- set gcore_name "${::binfile}.gcore"
- set gcore_supported [gdb_gcore_cmd "$gcore_name" "saving gcore"]
+ set gcore_host [host_standard_output_file $::testfile.gcore]
+ set gcore_supported [gdb_gcore_cmd "$gcore_host" "saving gcore"]
if {!$gcore_supported} {
unsupported "couldn't generate gcore file"
return
}
- set corefile [gdb_remote_download host $gcore_name]
-
- gdb_test "core-file $corefile" \
+ gdb_test "core-file $gcore_host" \
"" \
"loading_corefile" \
"A program is being debugged already\\\. Kill it\\\? \\\(y or n\\\) " \
--
2.35.3
prev parent reply other threads:[~2024-04-24 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:36 [pushed 1/2] [gdb/testsuite] Fix gdb.threads/threadcrash.exp with glibc debuginfo Tom de Vries
2024-04-24 13:36 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424133622.4639-2-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).