Re: [PATCH v4] gdb/testsuite: Add gdb.base/memops-watchpoint.exp

[Kevin Buettner <kevinb@redhat.com>]

On Thu, 25 Apr 2024 22:46:26 -0300
Thiago Jung Bauermann <thiago.bauermann@linaro.org> wrote:

> Test behaviour of watchpoints triggered by libc's memset/memcpy/memmove.
> These functions are frequently optimized with specialized instructions
> that favor larger memory access operations, so make sure GDB behaves
> correctly in their presence.
> 
> There's a separate watched variable for each function so that the testcase
> can test whether GDB correctly identified the watchpoint that triggered.
> 
> Also, the watchpoint is 28 bytes away from the beginning of the buffer
> being modified, so that large memory accesses (if present) are exercised.
> 
> PR testsuite/31484
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31484
> ---
> 
> Changes in v4:
> - Also accept memmove symbol for memcpy watchpoint test (Suggested by Kevin).
> 
> Changes in v3:
> - Reworked "continue until memset/memcpy/memmove watchpoint hits" tests to
>   have a chance to work even without libc debug info (Suggested by Kevin).
> - Dropped "require libc6_has_debug_info" call (Suggested by Kevin).
> 
> Changes in v2:
> - Ensure watchpoints are aligned to 4 bytes.
> - Add kfail for arm-linux.

LGTM, plus I didn't find any problems while testing on Fedora 39 x86_64,
both with and without debuginfo.

Approved-by: Kevin Buettner <kevinb@redhat.com>