From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id D86EE385E836 for ; Wed, 8 May 2024 20:22:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D86EE385E836 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=jetbrains.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jetbrains.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D86EE385E836 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715199752; cv=none; b=KGXyIAaFgIPoYGS8wJz32T7XkS9sDxrhONuwSd3W6fzIscpvgejH3hjJtE/M6iPM64HRwiaSrusw6bRShkV5aRQlQLri1pT+VnXeYzARGOJ6bM3paGk9E6hTouUjG3yjl6fpz1bBSPR4v4QSsAnY+iEaQOU0tsdGv6fnNtxHLmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715199752; c=relaxed/simple; bh=5zGpLlI/XJPBxrwtWtgzS6JQV+2vM0DYdU/3HTV7XPs=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=eszg4swoxXrmOi7DObHE79FPZIXpF25ITjai4XJBV49uAF/kaT1aTWYvwLpDTkeVuerbQV7bLEv8gx3BYn3In+KKGgxewriEmsw71Xq1/hbG+/TW18lY5ytgJCgM0ryWXMR99DgK7+IyGb3079zVtAK9NHtatoYOwPj5icFHkME= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-41fc53252ceso1218905e9.0 for ; Wed, 08 May 2024 13:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetbrains.com; s=googleapps; t=1715199749; x=1715804549; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ahNEqVszGfzpknW3TJmjuCzjeKyJdiflo9x1g834hyQ=; b=f78P/SIeSae+vhiUGD1WrDcgbHZV9F0Wkpy6Bs44jgmIo8J/fuOPZRJi5REgq2WIMx d1/rkNBVEJa1qFY2CmsHubi/MJiF3veEbrvcIKKV5GCRaqvc+2XX2OMaOE0DyBTdJHed 0AOJqgWm33t8e4LRjn2EHAO62eZjNyGxrub1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715199749; x=1715804549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ahNEqVszGfzpknW3TJmjuCzjeKyJdiflo9x1g834hyQ=; b=PJ/3xzO9ujkWXz0c2ngyrooiMIhIPjamuKdbzGjICUB4EaasHXgXRTj27XvmXdymNC ikBUfie1qQwu34KKnGHArkvfJf8f36J6JSt07qQD9IsDMrE0An9WLQGcFexlRVDe945r d0pi+Sddjx1HAlynRj10ASLJlfxHHENA3icS1JUFcnhzafXT5FddLMkQYhlZdwK/KX4r gDkbLNtBPCbq/D2L5aegM6UMBnr/rCtIgWljhSbiVo6fLeJYcPYN+xk71VG1oUri5i7u HQMAWs34RuZ0u9mkMdolpOUuXpaIrTIfR5AdFrEEktEYnO2iHcHn3caR0etm3NSeli+0 Tb/g== X-Gm-Message-State: AOJu0Yzucsf9gY/hfNPVOl/gQDdj/2Pp01So/gAG+Iq8KKXfz4Y52g1o TSb7C48FOe4gi7jr0si1JaHqxwrpjxI2LE8uPhemrkaHLWjcQBItX0LkAzDVkoj7upDLg9dF+Zc = X-Google-Smtp-Source: AGHT+IGEFxddJ2mDTXhAUKJkXxrUABSQ+cn889NDnfYOqb5EJZh30n1bXfRVvqWjP2a7q724JKkp9A== X-Received: by 2002:a05:600c:3155:b0:41b:d8ef:8dfc with SMTP id 5b1f17b1804b1-41f71cc25d0mr27210875e9.7.1715199749488; Wed, 08 May 2024 13:22:29 -0700 (PDT) Received: from lubuntu2.labs.intellij.net (ad96e1c12.dsl.de.colt.net. [217.110.28.18]) by smtp.gmail.com with ESMTPSA id bi18-20020a05600c3d9200b0041bff91ea43sm3398186wmb.37.2024.05.08.13.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 13:22:29 -0700 (PDT) From: Dmitry Neverov To: gdb-patches@sourceware.org Cc: dmitry.neverov@jetbrains.com Subject: [PATCH v3][PR symtab/30520 v2 3/4] gdb/symtab: compute match_type outside the loop Date: Wed, 8 May 2024 22:22:18 +0200 Message-Id: <20240508202219.3584915-3-dmitry.neverov@jetbrains.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240508202219.3584915-1-dmitry.neverov@jetbrains.com> References: <20240508202219.3584915-1-dmitry.neverov@jetbrains.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It will be used for all segments in a qualified name, not only the last one. --- gdb/dwarf2/read.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 8da0af01d72..48d5dc11d1d 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -16637,6 +16637,9 @@ cooked_index_functions::expand_symtabs_matching language_ada }; + symbol_name_match_type match_type + = lookup_name_without_params.match_type (); + for (enum language lang : unique_styles) { std::vector name_vec @@ -16693,8 +16696,6 @@ cooked_index_functions::expand_symtabs_matching "x::a::b". */ if (symbol_matcher == nullptr) { - symbol_name_match_type match_type - = lookup_name_without_params.match_type (); if ((match_type == symbol_name_match_type::FULL || (lang != language_ada && match_type == symbol_name_match_type::EXPRESSION))) -- 2.40.1