Re: [PATCH v5] [gdb/testsuite] New test: gdb.base/check-errno.exp

[Kevin Buettner <kevinb@redhat.com>]

On Fri, 10 May 2024 10:40:42 +0200
Tom de Vries <tdevries@suse.de> wrote:

> Hi Kevin,
> 
> I applied the patch and tested without and with debug info on leap 15.5, 
> and only got passes and xfails, so that looks good.  Likewise on tumbleweed.
> 
> One nit:
> ...
> $ git show --check --pretty=%s
> New test: gdb.base/check-errno.exp
> 
> gdb/testsuite/gdb.base/check-errno.exp:38: trailing whitespace.
> +# there were always scenarios in which printing errno was problematic.
> ...

Fixed (in my local tree).

> I tested this using make-check-all.sh, and got:
> ...
> (gdb) PASS: gdb.base/check-errno.exp: default: continue to breakpoint: 
> main-breakpoint
> ptype errno^M
> Cannot find thread-local storage for Thread 14233.14233, shared library 
> /lib64/libc.so.6:^M
> Remote target failed to process qGetTLSAddr request^M
> (gdb) FAIL: gdb.base/check-errno.exp: default: ptype errno
> ...
> with f.i. target board native-extended-gdbserver/native-gdbserver, I'm 
> hoping that's easy to fix in the test-case.

Fixed - and yes, it was easy.

Thanks for the review.

Kevin