public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
To: gdb-patches@sourceware.org
Cc: abdul.b.ijaz@intel.com, christina.schimpe@intel.com,
	felix.willgerodt@intel.com, keiths@redhat.com, tom@tromey.com
Subject: [PATCH v3 0/1] gdb, testsuite: Handle unused compiler option fdiagnostics-color=never.
Date: Wed, 15 May 2024 22:30:13 +0200	[thread overview]
Message-ID: <20240515203014.3160-1-abdul.b.ijaz@intel.com> (raw)

From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>

Hi All,

This patch updates the handling of '-fdiagnostics-color=never' in the
function 'univeral_compile_options' of gdb.exp file.  Before this change
it only verifies the support of '-fdiagnostics-color=never' for the "C"
source file.  So while running tests with assembly source file (.s), many
of them are not able to run on icx/clang compilers because
'-fdiagnostics-color=never' option is not supported.  After this change,
this function is split into multiple functions to check the support for
different type of sources individually.

Changes since V2:

* Added reason in the comment about handling the option only for Assembly
  source files ".s" type and not for ".S" type files.

V2 patch:
https://sourceware.org/pipermail/gdb-patches/2024-May/209178.html

V1 patch:
https://sourceware.org/pipermail/gdb-patches/2024-March/207477.html

Thanks & Best Regards
Abdul Basit

Ijaz, Abdul B (1):
  gdb, testsuite: Handle unused compiler option
    fdiagnostics-color=never.

 gdb/testsuite/lib/gdb.exp | 54 +++++++++++++++++++++++++++++++--------
 1 file changed, 44 insertions(+), 10 deletions(-)

-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


                 reply	other threads:[~2024-05-15 20:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240515203014.3160-1-abdul.b.ijaz@intel.com \
    --to=abdul.b.ijaz@intel.com \
    --cc=christina.schimpe@intel.com \
    --cc=felix.willgerodt@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).