[PATCH] Default dwarf_synchronous to true

[PATCH] Default dwarf_synchronous to true

[Tom Tromey]

Unfortunately the background DWARF reading series introduced a number
of races, as repored by thread sanitizer.  This patch changes gdb to
disable this feature for the time being -- in particular for the gdb
15 release.

I've filed a bug and linked all the known races to it.  Once those are
fixed we can re-enable this feature by default.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31751
---
 gdb/dwarf2/read.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index e8416905163..4818da58acb 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -739,7 +739,7 @@ show_dwarf_max_cache_age (struct ui_file *file, int from_tty,
 }
 
 /* When true, wait for DWARF reading to be complete.  */
-static bool dwarf_synchronous = false;
+static bool dwarf_synchronous = true;
 
 /* "Show" callback for "maint set dwarf synchronous".  */
 static void
-- 
2.44.0

Re: [PATCH] Default dwarf_synchronous to true

[Tom Tromey]

>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:

Tom> Unfortunately the background DWARF reading series introduced a number
Tom> of races, as repored by thread sanitizer.  This patch changes gdb to
Tom> disable this feature for the time being -- in particular for the gdb
Tom> 15 release.

Tom> I've filed a bug and linked all the known races to it.  Once those are
Tom> fixed we can re-enable this feature by default.

This fixes the various races that were seen, and it is needed for the 15
release, so I'm checking it in now.

Tom