Re: [PING 5][PATCH] gdb: Fix missing first breakpoint in schedule-multiple mode

[Kevin Buettner <kevinb@redhat.com>]

Hi Ciaran,

On Fri, 17 May 2024 15:18:13 +0000
Ciaran Woodward <ciaranwoodward@xmos.com> wrote:

> Ping again - this (or something similar) is required for working with multiple inferiors on a remote if
> you connect to the remote while the inferiors are already running.
> 
> There is a reproduction description here: https://sourceware.org/pipermail/gdb-patches/2022-July/191092.html
> 
> I was reminded of this from some discussion in IRC
> 
> (I include the original message below since it is such an old patch)
> 
> Would it be helpful for me to write a test for this? I have a reproduction example in the linked archive,
> but it requires running gdbserver twice and I'm not at all familiar with the test system. Is it feasible?

I applied (via "git am") your patch from 2022.  While applying it, git
complained about the following whitespace problems:

Applying: gdb: Fix missing first breakpoint in schedule-multiple mode
/mesquite2/sourceware-git/binutils-gdb/.git/worktrees/worktree-review/rebase-apply/patch:15: indent with spaces.
        inferior->control.stop_soon = NO_STOP_QUIETLY;
/mesquite2/sourceware-git/binutils-gdb/.git/worktrees/worktree-review/rebase-apply/patch:30: indent with spaces.
         the current thread.  */
warning: 2 lines add whitespace errors.

But, those nits aside, I was able to do a build with your patch
and used your reproducer to verify that the problem still exists in
current GDB and also that your patch fixes that problem.

Using the information you've provided, I think it should be possible
to write a gdb test.  It would definitely be appreciated!

Skimming your patch, it looks reasonable to me, but I haven't really
studied it yet.  I'll give it a closer look and do some more testing
as well...

Kevin