From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 11D563865488 for ; Mon, 27 May 2024 14:18:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11D563865488 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11D563865488 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716819503; cv=none; b=M7LkCM3D5MHMqXAdEiDG8cfXQsZjdiIEXbydKDxZQHRSkoUQb8t22uXlaNZQEB9LlcIaILkNL0FWGqsA7X/pgHNbwNFc1+DiXphspnmfMBJQpcQHu9sjjz6uMZDwpj3QOlA5C4WWy3cztoc2l8aeZUtYChK4arolLFELwVoMb6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716819503; c=relaxed/simple; bh=ZULF+AvwxH5DZYZVruKF9lAs1hSTmZF5w40FfUHg1nQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=rIiXtbTm2U2v+W46k80/V1Wnyon3ssuurk2W89lDvv+gUKfeovNlrCfu6OhoTZ/lcRVyL2gvIVq7so/iQbZvhf+1hYK7/t6VubO2pKF4/R5/lCUSDyNtXdNCaW6UBYOS3wAs+P1YCr+3tl9fi2l44TA463h5wigeicuvy9dghSA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 079A81FDC5 for ; Mon, 27 May 2024 14:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716819491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dCMg0hHnthqLinNafmgPNhAPmJVVNeBnmD5jf1JhYHQ=; b=j5opTD2Xik2kA5Kt+W0/8zKzF0Ka1YdSwmEbsxZauCVIGDQs+YrDCj4mxNeJ7eojmy1Ore Xtq4xT72IVOTa0gOI8LXYfNR3AgmveJrLcPLIF3cWKMYXuqAGDG06ahy6iMphxQr9a83cV 1m5Go4qLvhJh7f3wR0NRIkf92xeRDxU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716819491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dCMg0hHnthqLinNafmgPNhAPmJVVNeBnmD5jf1JhYHQ=; b=HHgobkBckLWRZEN+Lva6pQkCRYiwx71o6v0WJIJdlvjs0ucKo6wKhaSRPF0r4JO0OTfnEh 59HemmPGaLOWplAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=j5opTD2X; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HHgobkBc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716819491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dCMg0hHnthqLinNafmgPNhAPmJVVNeBnmD5jf1JhYHQ=; b=j5opTD2Xik2kA5Kt+W0/8zKzF0Ka1YdSwmEbsxZauCVIGDQs+YrDCj4mxNeJ7eojmy1Ore Xtq4xT72IVOTa0gOI8LXYfNR3AgmveJrLcPLIF3cWKMYXuqAGDG06ahy6iMphxQr9a83cV 1m5Go4qLvhJh7f3wR0NRIkf92xeRDxU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716819491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dCMg0hHnthqLinNafmgPNhAPmJVVNeBnmD5jf1JhYHQ=; b=HHgobkBckLWRZEN+Lva6pQkCRYiwx71o6v0WJIJdlvjs0ucKo6wKhaSRPF0r4JO0OTfnEh 59HemmPGaLOWplAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E4A4613A56 for ; Mon, 27 May 2024 14:18:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uISHNiKWVGbITwAAD6G6ig (envelope-from ) for ; Mon, 27 May 2024 14:18:10 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 3/3] [gdb/symtab] Note success at debuginfod verbose level 2 Date: Mon, 27 May 2024 16:18:08 +0200 Message-Id: <20240527141808.31563-3-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240527141808.31563-1-tdevries@suse.de> References: <20240527141808.31563-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 079A81FDC5 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -3.01 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Expand debuginfod verbose level 2 by also mentioning download successes: ... Downloading separate debug info for crc_mismatch-2...^M Download succeeded: separate debug info for crc_mismatch-2.^M Reading symbols from $client_cache/$hex/debuginfo...^M ... Tested on x86_64-linux. --- gdb/debuginfod-support.c | 8 ++++++++ .../gdb.debuginfod/build-id-no-debug-warning.exp | 2 ++ gdb/testsuite/gdb.debuginfod/crc_mismatch.exp | 10 +++++++--- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c index e65afb7523f..fe735756f72 100644 --- a/gdb/debuginfod-support.c +++ b/gdb/debuginfod-support.c @@ -297,6 +297,14 @@ print_outcome (int fd, const char *desc, const char *fname) desc, styled_string (file_name_style.style (), fname)); } + if (fd >= 0 && debuginfod_verbose >= 2) + { + ui_file *outstream = get_unbuffered (gdb_stdout); + gdb_printf (outstream, + _("Download succeeded: %s %ps.\n"), + desc, + styled_string (file_name_style.style (), fname)); + } } /* See debuginfod-support.h */ diff --git a/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp b/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp index d63957ac05c..1f80dee9e33 100644 --- a/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp +++ b/gdb/testsuite/gdb.debuginfod/build-id-no-debug-warning.exp @@ -156,6 +156,8 @@ proc_with_prefix local_debuginfod { } { [multi_line \ "Reading symbols from ${build_id_debug_file}\\.\\.\\." \ "Downloading separate debug info for ${build_id_debug_file}\\.\\.\\." \ + [string_to_regexp \ + "Download succeeded: separate debug info for ${build_id_debug_file}."] \ "Reading symbols from ${cache}/\[^\r\n\]+\\.\\.\\.(?:\r\nExpanding full symbols from \[^\r\n\]+)*"] \ "debuginfod running, info downloaded, no warnings" } diff --git a/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp b/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp index 6dcabf60357..8391e8f4a01 100644 --- a/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp +++ b/gdb/testsuite/gdb.debuginfod/crc_mismatch.exp @@ -126,10 +126,14 @@ proc_with_prefix local_debuginfod { } { # CRC mismatch should not be reported now because the correct debuginfo # should be fetched from debuginfod. - gdb_test "file [standard_output_file crc_mismatch-2]" \ + set binfile2 [standard_output_file crc_mismatch-2] + gdb_test "file $binfile2" \ [multi_line \ - "Reading symbols from ${escapedobjdirsubdir}/crc_mismatch-2\\.\\.\\." \ - "Downloading.*separate debug info for ${escapedobjdirsubdir}/crc_mismatch-2\\.\\.\\." \ + [string_to_regexp "Reading symbols from $binfile2..."] \ + [string_to_regexp \ + "Downloading separate debug info for $binfile2..."] \ + [string_to_regexp \ + "Download succeeded: separate debug info for $binfile2."] \ "Reading symbols from ${cache}/\[^\r\n\]+\\.\\.\\.(?:\r\nExpanding full symbols from \[^\r\n\]+)*"] \ "debuginfod running, info downloaded, no CRC mismatch" } -- 2.35.3