From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 4CE5F3858C78 for ; Mon, 27 May 2024 21:47:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CE5F3858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CE5F3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716846450; cv=none; b=GidpH3cV/FeEnF89YClMpitF5g5O2fhkplsWbWXrzNNfQnohW18DwuqH9dPrdTsCj52OIvU/3uA8TPiIcmgalNHPlVNMboV3NbS0pJ38QJU8U0WGmAcXgUQ3Xjo2M5Q2mTjuPDBtDOUqvkDq2NnHsyllIHpknzD6pyrCVRtbZl4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716846450; c=relaxed/simple; bh=szDNtSZoptz2jxJ9rryXG4dbuDs846C5RC1pwNmae+c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jS4x/EyFDXlz2MytqNT/uMSoRbwN5pE2L3VCzqwEnTc6WH5l8nzgAkzmj8U3AaUf0RAmpauLfWM4E52TwooWV2S15gMF5+RGMCi8R0O8aqBxuJ39Vg/3MrK/EwUdbtGLKT2os3l9eob0FPFwtu1lQsfCdXxJTpcD8S+4btkscgc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id BewHsW5wGjfBABiBksEp70; Mon, 27 May 2024 21:47:28 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id BiBjso4GXQJKPBiBjsg9Eh; Mon, 27 May 2024 21:47:28 +0000 X-Authority-Analysis: v=2.4 cv=EeHOQumC c=1 sm=1 tr=0 ts=6654ff70 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=TpHVaj0NuXgA:10 a=Qbun_eYptAEA:10 a=iR9pglaIY2berTjlsFgA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tebrFVgwDbtQ6TUh9Djg1PByJDTFl1V6kQyP1iZHWh0=; b=K8zzkkurrBpdBGOBRLv6l/0/+Q vcPKAlzJBavLN0zoUibRBtP1fLnjg3gszRR4WaF/Wv8pA7VvXSwOqvu+W+sy4FgUadbHOlbJ9WC1G 5id+F+IVMEKWkPYVQ2npElFUU; Received: from 75-166-134-4.hlrn.qwest.net ([75.166.134.4]:60222 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1sBiBj-002m3z-0W; Mon, 27 May 2024 15:47:27 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Use bool in thread_events Date: Mon, 27 May 2024 15:47:16 -0600 Message-ID: <20240527214716.98382-1-tom@tromey.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.4 X-Source-L: No X-Exim-ID: 1sBiBj-002m3z-0W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-4.hlrn.qwest.net (localhost.localdomain) [75.166.134.4]:60222 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPSqplY78TEb7YwzxK8Tp3mVS/LKp/is5ealH08Bnpv7wfcIaTIrbznwG6lYjmZxXJObmJxuX6ZDQym8jpoHv5vsL+Vz+KQxCBmh2LN5SgMR1mS2uKNe nzDNko0WGIVPPPsQkVCQhgwTxQ2XDyaH99LydRXHyILK9G7EQzf4ELGo0C1DFl/1CqAHlMtGgB3Fct8bJd1kRzWe5sMXM13LWC8= X-Spam-Status: No, score=-3020.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This changes target_ops::thread_events and target_thread_events to use 'bool'. The callers were already doing this. Tested by rebuilding. --- gdb/amd-dbgapi-target.c | 4 ++-- gdb/linux-nat.c | 4 ++-- gdb/linux-nat.h | 2 +- gdb/remote.c | 4 ++-- gdb/target-delegates.c | 12 ++++++------ gdb/target.c | 2 +- gdb/target.h | 4 ++-- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c index fcde6d27ffb..073270f0c21 100644 --- a/gdb/amd-dbgapi-target.c +++ b/gdb/amd-dbgapi-target.c @@ -269,7 +269,7 @@ struct amd_dbgapi_target final : public target_ops struct gdbarch *thread_architecture (ptid_t) override; - void thread_events (int enable) override; + void thread_events (bool enable) override; std::string pid_to_str (ptid_t ptid) override; @@ -1805,7 +1805,7 @@ amd_dbgapi_target::thread_architecture (ptid_t ptid) } void -amd_dbgapi_target::thread_events (int enable) +amd_dbgapi_target::thread_events (bool enable) { m_report_thread_events = enable; beneath ()->thread_events (enable); diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 48ecd3627ca..c95d420d416 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -279,7 +279,7 @@ struct simple_pid_list static struct simple_pid_list *stopped_pids; /* Whether target_thread_events is in effect. */ -static int report_thread_events; +static bool report_thread_events; static int kill_lwp (int lwpid, int signo); @@ -4618,7 +4618,7 @@ linux_nat_target::fileio_unlink (struct inferior *inf, const char *filename, /* Implementation of the to_thread_events method. */ void -linux_nat_target::thread_events (int enable) +linux_nat_target::thread_events (bool enable) { report_thread_events = enable; } diff --git a/gdb/linux-nat.h b/gdb/linux-nat.h index 4dcbe9e170a..92b16f7414e 100644 --- a/gdb/linux-nat.h +++ b/gdb/linux-nat.h @@ -78,7 +78,7 @@ class linux_nat_target : public inf_ptrace_target bool stopped_by_hw_breakpoint () override; bool supports_stopped_by_hw_breakpoint () override; - void thread_events (int) override; + void thread_events (bool) override; bool supports_set_thread_options (gdb_thread_options options) override; diff --git a/gdb/remote.c b/gdb/remote.c index 42b446c7e27..965427c96a0 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -965,7 +965,7 @@ class remote_target : public process_stratum_target int async_wait_fd () override; - void thread_events (int) override; + void thread_events (bool) override; bool supports_set_thread_options (gdb_thread_options) override; @@ -15191,7 +15191,7 @@ remote_target::async (bool enable) /* Implementation of the to_thread_events method. */ void -remote_target::thread_events (int enable) +remote_target::thread_events (bool enable) { struct remote_state *rs = get_remote_state (); size_t size = get_remote_packet_size (); diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c index 5fb1c80a9c3..dd20e1404c3 100644 --- a/gdb/target-delegates.c +++ b/gdb/target-delegates.c @@ -105,7 +105,7 @@ struct dummy_target : public target_ops void async (bool arg0) override; int async_wait_fd () override; bool has_pending_events () override; - void thread_events (int arg0) override; + void thread_events (bool arg0) override; bool supports_set_thread_options (gdb_thread_options arg0) override; bool supports_non_stop () override; bool always_non_stop_p () override; @@ -282,7 +282,7 @@ struct debug_target : public target_ops void async (bool arg0) override; int async_wait_fd () override; bool has_pending_events () override; - void thread_events (int arg0) override; + void thread_events (bool arg0) override; bool supports_set_thread_options (gdb_thread_options arg0) override; bool supports_non_stop () override; bool always_non_stop_p () override; @@ -2165,24 +2165,24 @@ debug_target::has_pending_events () } void -target_ops::thread_events (int arg0) +target_ops::thread_events (bool arg0) { this->beneath ()->thread_events (arg0); } void -dummy_target::thread_events (int arg0) +dummy_target::thread_events (bool arg0) { } void -debug_target::thread_events (int arg0) +debug_target::thread_events (bool arg0) { target_debug_printf_nofunc ("-> %s->thread_events (...)", this->beneath ()->shortname ()); this->beneath ()->thread_events (arg0); target_debug_printf_nofunc ("<- %s->thread_events (%s)", this->beneath ()->shortname (), - target_debug_print_int (arg0).c_str ()); + target_debug_print_bool (arg0).c_str ()); } bool diff --git a/gdb/target.c b/gdb/target.c index a5c92a8a511..ddf10c28e1c 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -4286,7 +4286,7 @@ target_async (bool enable) /* See target.h. */ void -target_thread_events (int enable) +target_thread_events (bool enable) { current_inferior ()->top_target ()->thread_events (enable); } diff --git a/gdb/target.h b/gdb/target.h index 394e377d034..81de4a678c3 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -755,7 +755,7 @@ struct target_ops potential optimization is missed. */ virtual bool has_pending_events () TARGET_DEFAULT_RETURN (false); - virtual void thread_events (int) + virtual void thread_events (bool) TARGET_DEFAULT_IGNORE (); /* Returns true if the target supports setting thread options OPTIONS, false otherwise. */ @@ -1920,7 +1920,7 @@ extern bool target_is_async_p (); extern void target_async (bool enable); /* Enables/disables thread create and exit events. */ -extern void target_thread_events (int enable); +extern void target_thread_events (bool enable); /* Returns true if the target supports setting thread options OPTIONS. */ -- 2.44.0