From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 0FF333846423 for ; Tue, 28 May 2024 19:24:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FF333846423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0FF333846423 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716924243; cv=none; b=hJJKU0FIDsOZY42EQQweAuRtxboyU4v1GzefhbT8O4UYbnmFVqeP/58Ec3L/MUHCrbpcweVSG1eA2656htQK5xAk/6bjP01okGWMHkUTDGJON2n3949f0tn88fGGUPds50Nv4LiHeYJUVFY99+mJsViD/6E2sXOOaHK/RNPUjnE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716924243; c=relaxed/simple; bh=kSdX7IJiUmvt+XGGq/tMyDC7jT4K1QIbaCX8H3GwQcA=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=eBqK/Vp68mE+SOr+bWe/h1NM51ZyyAVXDxpxoopJ7oTUGFwaVQkNRKzZRl9gGTKa4NU6crEI5h/LVgPON0NIwJSFleNKoS+lqFWwnhAdQNfen4JKSJ5AwwzTcxw4NjEHdX7kKscP2n4K3qhsiruVAp79kctm7r7oSpfNhiHcGgY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id C17FscYujjfBAC2QSsPW6g; Tue, 28 May 2024 19:24:00 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id C2QQsUlqK9zHMC2QQsDnej; Tue, 28 May 2024 19:23:58 +0000 X-Authority-Analysis: v=2.4 cv=fo4XZ04f c=1 sm=1 tr=0 ts=66562f4e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=TpHVaj0NuXgA:10 a=Qbun_eYptAEA:10 a=43yMY_HhHjItmh1-C9QA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j92+FHR81ftVV72f5o6xjKyepGuQFP2AWljO+o/EiT4=; b=mlTIWxbpSDfu1KeVAZHwSyPrh/ r8Uo7UvZnEeUsrN09og8n1hefLAwRaCUyKPF9MblaFF0nr3yq2oXLhEyeldCEV4blw+6knlMym5ax I617742KIp0yDGWsHNNmJQ9ZB; Received: from 75-166-134-4.hlrn.qwest.net ([75.166.134.4]:40340 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1sC2QP-000PSC-2l for gdb-patches@sourceware.org; Tue, 28 May 2024 13:23:57 -0600 From: Tom Tromey Date: Tue, 28 May 2024 13:23:54 -0600 Subject: [PATCH v2 1/5] Compare section index in lookup_minimal_symbol_by_pc_section MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240528-dwarf-race-relocate-v2-1-a8d042e75925@tromey.com> References: <20240528-dwarf-race-relocate-v2-0-a8d042e75925@tromey.com> In-Reply-To: <20240528-dwarf-race-relocate-v2-0-a8d042e75925@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.13.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.4 X-Source-L: No X-Exim-ID: 1sC2QP-000PSC-2l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-4.hlrn.qwest.net ([192.168.0.21]) [75.166.134.4]:40340 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBwGgOXmZK663JbV+S4mBWE/5aYM9PYfN8pOSZhobDpj88Bzb+MWPMs8tgYtaNPBNi7Xr2x4vnoYkWrikjWfLS8R5AuI8OopnxpH2F5dWHYsQPX2i+Eo ry6LQrx5bxzRsg8rt5o0xikp5KXf3Uh2cfSxv+kQTPGtbuWl+YfQvEeOtdmdIF3P++KDwT3Ll8SmdC+k54enmboFNPbMLJulDrY= X-Spam-Status: No, score=-3020.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This changes lookup_minimal_symbol_by_pc_section to compare the section index when comparing two symbols. This is ok because the symbols in question always come from the same objfile. This is slightly more efficient. --- gdb/minsyms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 38176c4bdcb..ea557d3625f 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -900,8 +900,8 @@ lookup_minimal_symbol_by_pc_section (CORE_ADDR pc_in, struct obj_section *sectio && (msymbol[hi].size () == msymbol[hi - 1].size ()) && (msymbol[hi].unrelocated_address () == msymbol[hi - 1].unrelocated_address ()) - && (msymbol[hi].obj_section (objfile) - == msymbol[hi - 1].obj_section (objfile))) + && (msymbol[hi].section_index () + == msymbol[hi - 1].section_index ())) { hi--; continue; -- 2.44.0