From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2412::600]) by sourceware.org (Postfix) with ESMTPS id B56EA3846088 for ; Tue, 28 May 2024 19:59:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B56EA3846088 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B56EA3846088 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2412::600 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1716926387; cv=pass; b=WNCwx1I2HyyhEbvh7N/wn3bNqjhBzGf+piox5qQEzmB9o+h7/rYAGsw7DxPicebckLPa7ig0xej8NkGkqB0ziHh64aEKCFh4CPyoa/l2fm5TGloNIqcahbV2h3qx3qJFf58z+otIUH6gJaKQBaYERYpSWs+A84cYO4FPcpzFbHc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1716926387; c=relaxed/simple; bh=mt8uWdr4Xw8I8n/hJTd6/YBsj00f5fuUbUzHbsugGvw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=DMRUrCAS9qmpafEl4rGTa1xpOqo1XPuSAdlbr8avJqg2Bv+JRZ5tUSEx87Igwn1p04cOJtzQH4fy0fwJA0O2Z7sqe9zVOypNVy6aHeVdsh/qOgDfOwo2RgLqNFJnmrD1L5UpzZC/pQeLSf5jMPA++Nvf8O3XZqXcXya9kaCk0XY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e1GsDPPqrp/vo+4MVpCF2omsadaTvoK2131kftK0W+P/9M1APahZXuEhLT3PY7272pYQEZd7x+By9pk1nB0T2fPS1WeWMX7KVyvDKAAPlqA9cQKe1aI+1pjLIUBdo8m4UeUFUtYxUP6mGlyDJa1wE7DF0rAK+c1Rgsqq//HuwvTW8IDFckMDoM/wYtgmhIfiHttivxXSXPHC2M1980InUiZKgW3G5WUn8uQ5Rm55U4iJN6FE9VXm+NwzCway5Mnl3GAW8JCIf1Sm1F1bvDFrui8MSVKlOgzMNnIDUrlU4hVubHtWMbVfoVISDX4wlMrFxDc73BC8wGQ7pDY2LHI3tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qeg3VFqDxIN8+J+d30sdGMT3xrXJ/pMs953P6ifNVWE=; b=bmmc0Ee5waMJsZiaCivY7/fdEPp073bQUKvfOweS8RcSJtQsnLqP5P/TLcw9FObcpT3FSuhJTlgtpBkWTRg2n/NTYBNziycRTGLTKEMYbuYvuAIj0tVUu5thctyhLVsL+xA7Kcscrtl1xWh9SA8vubWSrAJ4vGbhSibJzX9er8sVKW+0vzuy9FauYFMLxm1NBjS9SWn5Tv1V9ZsicYG/POSb4xRdQH4H85BOFGflPtbMYoolA5i0oXwZ5TBHrquHH8PE6HI/bqwUjs7kDUF2isxAEqNRgRNimhq5wBaWLviBLwJE/8yHYhzTO0EnAZztP/WXGgiAYWMvDcppdal20Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=tromey.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qeg3VFqDxIN8+J+d30sdGMT3xrXJ/pMs953P6ifNVWE=; b=t/Edi6qRTj1XJghNHkTzdQOFH5DoFqfiGWpoaVpO69nj7Jc28YMDwxtMSAMjQkUMj0H0DUPnuqoUZLCvr3tkS7oZlN4pIJZe/2RDR0y0Ua7CQgd+G3MnfMMPpFuBNkRoOyaZZjf4tZZVYe14Aj4Rx7nPaUgFXeH3FkUdC65Fsts= Received: from MW4PR04CA0306.namprd04.prod.outlook.com (2603:10b6:303:82::11) by IA1PR12MB8496.namprd12.prod.outlook.com (2603:10b6:208:446::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Tue, 28 May 2024 19:59:43 +0000 Received: from CO1PEPF000044F1.namprd05.prod.outlook.com (2603:10b6:303:82:cafe::90) by MW4PR04CA0306.outlook.office365.com (2603:10b6:303:82::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30 via Frontend Transport; Tue, 28 May 2024 19:59:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F1.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7633.15 via Frontend Transport; Tue, 28 May 2024 19:59:42 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 28 May 2024 14:59:41 -0500 Date: Tue, 28 May 2024 20:59:32 +0100 From: Lancelot SIX To: Tom Tromey CC: Subject: Re: [PATCH] Use bool in thread_events Message-ID: <20240528195843.bpmnbm4jcvbqartl@khazad-dum> References: <20240527214716.98382-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240527214716.98382-1-tom@tromey.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F1:EE_|IA1PR12MB8496:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d8cea96-23f0-47d2-c335-08dc7f50b738 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|82310400017|36860700004|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?K7b/lD2Ex8WmSnqXlGazz1VuSlptmEFYI0b8OVtGv2+E1IbPCdC7xA9ZAl/I?= =?us-ascii?Q?SshKM6HSQtVMeOqvjh+o9lbUITIX0DPxU7UEUtPz10BdUDcBh+5B7yWUDnV3?= =?us-ascii?Q?4AVkHYMvMV/MGEF8ft7x+RU8y+G9rQFsTEE7Z0/5NnPHXQqkr8mtdz/xSq/8?= =?us-ascii?Q?kpWfyP/QziScsihaxKvF/jXJPtrlQ48SHfMBV3/c25Jc8SHM1FggEHgKaPu3?= =?us-ascii?Q?nrNpTsdqWkbGJAaeRsGHdRuNoEt52G6W4/Me/prZgO4BmZlxmwTR7g0s7mgk?= =?us-ascii?Q?RXTnjMEcgloE9VxzKiTa0jteOBITy7tgMwXdI+1Rf8SyNQ1Quk+wvKGn8RY/?= =?us-ascii?Q?kHvH1dgsMbRc15QlNekkJRTIstObYNWNmibFtsqglanYWkE12TnDU3Xlpj4e?= =?us-ascii?Q?vgFNiNfjVMLa3n4J1cfe+RpKJNBJed32tv8hRzk8QL3A/pHgBYlTQg4MkcWy?= =?us-ascii?Q?VmCIqUeyndRHr1ZH2MEwZutTCfFZ5dsIUIY4enK8m9kGeOLLv/WO3bFMneje?= =?us-ascii?Q?C3wv9tMobHDlPt8hnhTEgMwcs6/Pzxyl3W5O1RXj76D0RjqvP7EaYRUkrROT?= =?us-ascii?Q?E6t+S9z3URh+GsqpycAPF4AjRpikccQ4upSGpNWnhKP69m5hOQGz+RvoSgNc?= =?us-ascii?Q?qVE35Dp8j9RYHR9o+IHdk66Zzjhcir0jlo4jMBZ4ZqwVr3dLiKxFtjznotdm?= =?us-ascii?Q?H326Hmc+edcl208MGkHNxUJlEUNvkDDNgqwYM5Ba+C9Syam8AFJA7lAs5FDn?= =?us-ascii?Q?3l5NkF8Z2RCqVEPRUoYZasf4/Q+pCa/IKag4f2XUENuVZxRhai4MB56kFWak?= =?us-ascii?Q?bnPVW+mx2oSe4VQ/0umjJDJB0Nvx8o9+m+aW+lXA45GwVUWtFiWb2zCnm7rc?= =?us-ascii?Q?wzR+KZ4SyOMBT4vlhEdKr//Kgfg16YCG6Xo5gPKOnqcY0bZtqQed6rJub25P?= =?us-ascii?Q?rzVks55acAwSua+AoLHJFjxQd6CCcNa/q6yFYbYDBgojwTqNLtjkGj541tGH?= =?us-ascii?Q?/aCJw8zceiJw9vuAafUzrall+65zazDqt6EAizRZyo+yDcsSOuawKhkqR7CK?= =?us-ascii?Q?wdB75uG0W4vF5X9H8tk5kZRcSy6T1TPqJ4BX5RxYT45hfSunvAvOMIIfWs/s?= =?us-ascii?Q?k/ekhsA3a6d2aFk6kmL+h4xuyGFgIT3K78qi3Gayk65ncro5DetX80L25WG7?= =?us-ascii?Q?pI7MSlbuzDUKM2oiHFDzhjLDWqepTKr5IzCfwJYBbkV+0EQ/z4vRAWO5fBgf?= =?us-ascii?Q?lWgDHNTtlMUtJbRR5hmRlfM0rSg/ueFChS7mmFsxgvb81mjV9W1stDHky7AD?= =?us-ascii?Q?ZsnuYT0QvQIluw+QmX4AN6VlCcsqaBhdm0nMxxiRNdzUolyiYQcSxdKgkH0/?= =?us-ascii?Q?gFKcvBOvobAQ3HUcvp4KIrbotUYX?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(82310400017)(36860700004)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 19:59:42.5173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d8cea96-23f0-47d2-c335-08dc7f50b738 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8496 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 27, 2024 at 03:47:16PM -0600, Tom Tromey wrote: > This changes target_ops::thread_events and target_thread_events to use > 'bool'. The callers were already doing this. > > Tested by rebuilding. Hi, Just FYI, I did also rebuild with the amdgpu support (to catch amd-dbgapi-target.c), and all looks good to me. Reviewed-by: Lancelot Six Best, Lancelot.