From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic310-57.consmr.mail.ir2.yahoo.com (sonic310-57.consmr.mail.ir2.yahoo.com [77.238.177.30]) by sourceware.org (Postfix) with ESMTPS id B4B62385E838 for ; Fri, 31 May 2024 11:49:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4B62385E838 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B4B62385E838 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.177.30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717156150; cv=none; b=eSWggJnIdapqdqnQo4a8sYasve8KS7VoSVfZTR1dBIjoeuO0g15+ZodEsqKwbaA2l9WL8e84aUQLbIK1XEGc9Q1etwfyzbuV9X3HyYwc8Az+u5wtq/GJb4dSYhQLCpArYibloSvxycVvI04bcRlYCUt1t2Km9WzZdgRcwFO2aC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717156150; c=relaxed/simple; bh=uAhNbU6/+X3Etzv4IyXF6rcYJWvPXdR38srQnhuA6pk=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=nrmzrxIQI8G9/9MBcYhHvbRzGxiFL2GX5S+v4jShnuJdeqe1BIOmoJiuxCDPV/yQTGQ7EVx+NmuFeSwEWz2tOED8j2Cc4tFzlnWEsXorFO/5fe0AuBnW9mAUW3b0F7I6FEV3M1o41iC6oTEFLtjHx7YUC0119+M3kuH1dZyub9k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1717156139; bh=K9tPIDedWZQS5M4lhe+N0nZSaAqrzHbI2jiqqmW6kSc=; h=From:To:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=UpAeOXEnFSrX16aHPIEjjltYqtB5+qUJ5KJHtkLW80Pzmf81qnqbf7TCp2j/ObfwM9UuV5XHFy4SN6jBcXzQGwbVlc+DLDZa9yc+4UnyyLQ3+aRS8OSBejXRHIGfovbRy92pNPFIzNjpQPU7bofdYLytxGt1ShiE8WcZOTAsBqcVQ7JI4wydLaaMblYnPoyVBKhffbH9z7SlDDszgZahOjnpnQN4ti7WBVK0EsPJxQWp8HXsiCvXIni+vtnVtBPNFXO8/0vQZ3BQCCqHh//ZbXTR+bBnMr/bN6pTrYFpWbrWj6qvJcUYJjRGxDgfiWaQRNRTd9sFrnZXSAcof9uNRA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1717156139; bh=iqrzRnj+SljkNAKKpKrqLY57xE7NGPnDbqr0XDMlKru=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tDEjP/rZezZJO7vYQC2ljGS0wdJdaMQsu84LuYc2wTza+d/m7VNk6aZn4sJbTcTcPCQuZWpBDO3NJvvxD/AEUbGEka9yvp1K+IH67l3ujdxDoLkJx/ybSb0rxT+XBGkZ6zLiC2Iq57DALd1xMnFG6qG+LaWag83FKT8LnHsuV3lTNHypgzJ5k/XvWBuz0WceWA7Q+9wOGm2ZDEY9X0y735yduCl75EOxi9ABgpJQQY8lE1biEyMUYh0JLxrmder8A/JEXZ5J1MEHsz9YoSE9QBg0Zrfb7pLBJwSAFLcdAPM7soc1P1Jj5pors1r3DrSiKEM3qIuVe2/TI+PCNrnD5A== X-YMail-OSG: kQeCoIcVM1n9oph9t.kgSYTjZkQI3P9I9TVzxv9oarQ5E3ve6TmP2zk.qfUHsAH 3PRRJcuIoncOZ7mkyaCvHRfBo3DMOsc87TpCyH_vD22thU2bjK8eP.C77h6HnTuFW1dmhbGZu0mP LYaw.Des6ZBOSg5pIcfDT3kP7KlsFR5EYtdRPd8OOZmGzbhZdtidiw5k0WOBXCDtvWa4zy4MhUgM hfKzU.38DXdKCbxI.P6shURjqpWzHiWyDQ_B0PDoWBLO.xhdLSnrbL.Eri9aDZlkFVORiUHfGFab LOT2_KVeJTx3sTCD.tiLJqendkOWIGPum_1zbOrwry_sftTaaG_.OyeUo6G8UeDmHhmr1xucevtP 9cCS0GqRNBnMIszkxtCsOA9DlKoDPRCHSRhyjuuyM7z1pyBBa7hygnrN4Ph3cvubuqNSBhowq2h5 TguD3EHjAWnw3MhLMTXgu56ruVCDYV65h8bAGOOqEXXFKkiZcNnvc4vBjiIo2p1zKUbNbz7mJl.. 7RDsqXtYRDsmJdEJLJcZyPYJuoC_Cj44ely9.sbc5VXLTyfUOKi3bggo_8mqEy4QdCxYH4dOCzss 1Lso1MdxKTsqyChqJJ37KWB0qSM4Jxh6lI.hQs9wQXOmRsjbA6G6CoTTJMZQPEs7waAfRymMIjiW fflqWl2HMLnqWzFfAjIk1U7FmBPSImeh6XLi0yMcZxcINM6u9LwjrX0Vv.IvrEbIlIJJ4wnjszFv 4TY19RvnI20MiBkaaC0.wXvMpJ07C1KEmf3MNVZ40FsMa4RMLINhp4T.vy71CQ0nKYUgGMW22hPC s9GSQIHVyIOdsiVTbKCKeiG79bwQBenZs0Hg9jgA6x4yrTwNBSI7oE8TR8g8tyFiQi4mWXCT2gBH keTZ9qeUgMZcjwHymq22cyDygH_GEDIgGZJBveEXQLGeELXDoPgaTWtvqpAoyvs.UQN7O7.YToOI mvKNUvNuBAHDgNs5h.lM8U2BtM6AsfAq9JPiVwKTyGRrUoYJY7UnlvEpFU6FW5TUr9Mbs8JVpxV1 B8fmutEYotQqiamMyLRdzvVDjzpNI2cI_JViTtRidQJqqr78zKufEfwt7nEAaEOYMbwkz.ojcfQl JJ3rixUv2VKmyfNss4kuoVtA7ZTWUfeXMwqeu9YoqqIY63ThSAesgd7ptEVbFhYkzDkkiiLYk377 AWuWVG9zyVbhTz2niVQUNvZWwPVQzQLRq1no.LCe.I39S0rWw2.2yjrhKvUHJmenO5yoi6gWPw3K y.xFW_z2KPcp8vTNcJT0fA9MwqHLeNhQY7ofk.JRLD6WPFndf8EzK.zc0VqFHA9eBMvHZvTTT0eo HcfAcxgtana9407RLMJk8W_ljFWgrmEkJhSHX2yw81sAh0HLDUiErxbzpjEL2o2AmkMO6wdourd1 XhUuBQaEbQSepMrCGJPBbGrvbSz5uqmRQPAbHjnJZBFUsik8rQHxuzuWU_NwXWc3MEsa6klP03uH axTFJnGW554jrba9bVc9MIrwInfbUMlhtUF74hYhGa5fbn2pHfDY9rjrhE56C7V4zuJ6ktm8j_pP vJLn5ryut2MTcpawmZ53jyYjRBPk0sb7_5NwTwcHBYxmsI_tTv6fyZvVmysfGDo1ExE8WZQ_IYIx gqNylU_7L92Eyaay0mb0aQTfouXwddukeDL0BDvWwEbpeydEefc2a9cSrpi.ZaxZd9GpBAqu0Nta mQdcO6brKjuYOi_4JktvwgBiDgHdmel6AXFhTX0CEV8G9MN4cFHbLGyHWIWF0B2pSmvVAorXa8t0 FcMRxoLBsTdBe.ZcQn.PFz30E0gBKBGqq2ng_YuzoKLyTC7nAqpxeH4Z0RmbvnKWK625Z1Y3rwbX P1qczQhYm2DRxktpqPyqrE3gi3puSRxI7OF.nVpdlxDjilEjNbzQ01Qkl_9r_2xRaBtLiZZW1LTM vM__QYC5l3CWYlVQY_SUNC43PoGBBK8kXXpK_60vaZ_9fJQHAq9qosBkcwDJyVW0nKU5wKhzcNe4 EWuPHn6hpBUXzrDzBq02jVinqhu0hf4HORqRZxpsHRhn_CQFpJWdSRsx2s_OM_Y73Rv0CNR4Jhpd AvgEyNy2UcM4XQa.FM0BJxAAtFd2Ackvq.vUGh5v3TbaSFPEMzs03QCNV1_G5CCmvI1zHiVHKhRc DkjeN09JzD93tljS1U2Wp0Sh44YJO0BRCUoFJqX.oRD_HmuGBtOgSVWG8zqOSZLh..7qKNSqxrYh a6lnQvx2e8a.3pSAohI7lSetVYphI8UX5EInt X-Sonic-MF: X-Sonic-ID: c01aca3b-ece0-493a-af2c-8f8803f3a581 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Fri, 31 May 2024 11:48:59 +0000 Received: by hermes--production-ir2-7b99fc9bb6-g8flm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f2a29022cd5c5757e910e901fd112371; Fri, 31 May 2024 11:48:54 +0000 (UTC) From: Hannes Domani To: gdb-patches@sourceware.org Subject: [PATCH 5/5] Fix cast types for opencl Date: Fri, 31 May 2024 13:48:01 +0200 Message-Id: <20240531114801.2745-5-ssbssa@yahoo.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20240531114801.2745-1-ssbssa@yahoo.de> References: <20240531114801.2745-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Antivirus: Avast (VPS 240531-0, 05/31/2024), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The bitshift tests for opencl have these failures: print /x (signed char) 0x0f << 8 No type named signed char. (gdb) FAIL: gdb.base/bitshift.exp: lang=opencl: 8-bit, promoted: print /x (signed char) 0x0f << 8 print (signed char) 0x0f << 8 No type named signed char. (gdb) FAIL: gdb.base/bitshift.exp: lang=opencl: 8-bit, promoted: print (signed char) 0x0f << 8 Apparently opencl doesn't have the 'signed' modifier for types, only the 'unsigned' modifier. Even 'char' is guaranteed to be signed if no modifier is used, so this changes the casts to match this logic. --- gdb/testsuite/gdb.base/bitshift.exp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/bitshift.exp b/gdb/testsuite/gdb.base/bitshift.exp index cab82e1971e..dccc36b20ad 100644 --- a/gdb/testsuite/gdb.base/bitshift.exp +++ b/gdb/testsuite/gdb.base/bitshift.exp @@ -123,10 +123,12 @@ proc make_val_cast {lang signed bits val} { return "$val as ${sign_prefix}$bits" } else { # C-like cast. - if {$signed} { + if {!$signed} { + set sign_prefix "unsigned " + } elseif {$lang == "opencl"} { set sign_prefix "" } else { - set sign_prefix "un" + set sign_prefix "signed " } if {$bits == 8} { set type "char" @@ -143,7 +145,7 @@ proc make_val_cast {lang signed bits val} { } else { error "$lang: unsupported bits" } - return "(${sign_prefix}signed $type) $val" + return "(${sign_prefix}$type) $val" } } -- 2.35.1