From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 3A28F3858D39 for ; Mon, 3 Jun 2024 17:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A28F3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A28F3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717437459; cv=none; b=Qr0gJIbw6uhSsyiBuKiEeeembjhYaovy/S2PSryueiczFpzU9k07ZK0szm3TYEDh5VO0nHAsNhGHIzAS2eBfgkiDzWHjfevVRZGAUJyS748uwPDHfmLY0Z2y6FgaQVl3amYoQKBt7bfivBqcs3HB47LwX8PWqTJr9vFN8mBPKSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717437459; c=relaxed/simple; bh=Mr0C0uEW0niuB+z71a9LPwuQBc54Bym+rgQqA0T1W/s=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=Yd5xeITbPzgov04lr7YGw7zci4fpmiJUlgaKdhPApekaXfNf6KozH/QjLfQ6Rhu5uiStBJYtG0Kby8/WQd2/vNESUGxRegulaf2G6h+QqbboPt8IY3vE77frNsigv3qvoH1d7+ODkdMz+k0+rwKhHQ0Yk16vWLvE5DswcE8BCEs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-374a82e20deso709075ab.1 for ; Mon, 03 Jun 2024 10:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1717437456; x=1718042256; darn=sourceware.org; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:from:to:cc:subject:date:message-id:reply-to; bh=85a+RKTZ6Kj8AEuOiNNPpuyLvrGR3YeFMMUITjUSsvI=; b=PQNVJ/jOiKVpVmx0VtEc2gU15CJ0no7z8/wCtYdT/HLZGmz0z+4DBrZE3bq11CzucQ /A+tEgy34cDg2aEybpR3yEnXDEyB4C1XdI3KhtP2RQudZl34/dy5tnpwQSoAqZ5Fivf5 1rmysbZtcUGtKQ2zacYWCH7tNlIlXUN6s+v1+N33KQBMjdZSMu/dg5ebWBmKZXI+urwj jvD8X4Uh6/qRWoWo1sWvaXIdY5PEV3MlKgh5rv/ofazH7ur1PCtOdmucitANCmpi9ppN AL4IudCsF8yhSURXPnhCf0FB3WkdnTdsRudx67dSA2Su0P3RJ8y1xzvvEjbSVLLAfeWP A8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717437456; x=1718042256; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=85a+RKTZ6Kj8AEuOiNNPpuyLvrGR3YeFMMUITjUSsvI=; b=g3QKukY2jKcYOQ3OQJBvniEgZAg30Xeb8HVoY167hoHWKLDTnZFmDz0cORXmeWFJDE dipJnRlbltc9rCZeUm6dNvm2N2rqwqqZ1u6K6xav5XEHCU8A7wIWy7OLMJTsV8TLvrUC dmRSCm002ImwKXdT1WMBAN64TCZ9lr7Ruf5ZDcB2w/x8/hY+hJ439iJJj5i7suQ7L1Gw 6isKY97XMpsLIHXxqscJjr9FgFyReFj1XA3L2ILhbbHZH+VcXHmpm/el24+p//7a/nv+ iT6zSB5idJ1b4JM2LzdHaDzc1asySk+xYG3oWELD3lIT8ihMDN1PRsiGJcOq86dqCstF 2Oug== X-Gm-Message-State: AOJu0Yx5xWEvCJXNynRQ4UEQsaXuXHEMys11wTEmJl0M/G+pcgWWxb+u SfAI+ukVTqsCl1UxVaeWhwmRXMIFwKtARX8XWhkcFx9EfgsH2t+uVG1t6w12g+lKLzQObigxkiA = X-Google-Smtp-Source: AGHT+IHjZPHgRtvV/9eAer0OTTeyJBXF+8klUEEHaPNx05tcfcnSD+VpY8Wass1c7JUW7C2fFkgiXQ== X-Received: by 2002:a05:6e02:19ce:b0:374:8172:c24a with SMTP id e9e14a558f8ab-374a856a251mr3253595ab.11.1717437456139; Mon, 03 Jun 2024 10:57:36 -0700 (PDT) Received: from localhost.localdomain (75-166-134-4.hlrn.qwest.net. [75.166.134.4]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b4881d5d4dsm2084903173.64.2024.06.03.10.57.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 10:57:35 -0700 (PDT) From: Tom Tromey Subject: [PATCH 0/4] Require help text to fit in 80 columns Date: Mon, 03 Jun 2024 11:57:27 -0600 Message-Id: <20240603-doc-string-cols-v1-0-ad67124ba872@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAcEXmYC/x3MTQqDQAxA4atI1g2OY7HQq0gX8xPHQJuRREpBv HunXX6L9w4wUiaDe3eA0puNqzQMlw7SGqQQcm4G7/zVTW7EXBPariwFU30auiWPQ4x08+ShVZv Swp//cX40x2CEUYOk9fepyoWlfwXbSeE8vxOS7faBAAAA To: gdb-patches@sourceware.org X-Mailer: b4 0.13.0 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I noticed that "help info variables" was pretty ugly on my 80-column terminal. While fixing this, I was curious to know what other problems there might be, and I ended up writing a unit test to check for over-long lines in the help text. This series is the result. Regression tested on x86-64 Fedora 38. --- Tom Tromey (4): Call gdbpy_fix_doc_string_indentation for function help Wrap help strings at 80 columns Wrap help options when building help string Ensure that help text fits in 80 columns gdb/cli/cli-cmds.c | 3 +- gdb/cli/cli-decode.h | 3 ++ gdb/cli/cli-option.c | 60 +++++++++++++++++++++-------------- gdb/cli/cli-utils.c | 8 ++--- gdb/debuginfod-support.c | 12 +++---- gdb/infcmd.c | 6 ++-- gdb/memattr.c | 3 +- gdb/psymtab.c | 3 +- gdb/python/py-function.c | 2 ++ gdb/record-btrace.c | 10 +++--- gdb/record-full.c | 4 +-- gdb/record.c | 26 +++++++-------- gdb/regcache-dump.c | 6 ++-- gdb/symfile.c | 4 +-- gdb/symmisc.c | 3 +- gdb/unittests/command-def-selftests.c | 5 +++ 16 files changed, 93 insertions(+), 65 deletions(-) --- base-commit: 7c493aa7e73e6718790f6b4a01a39ff4146cba4a change-id: 20240603-doc-string-cols-0fd31bbe72e2 Best regards, -- Tom Tromey